Make TextControlElement::indexForVisiblePosition() not to use temporary Range

third_party/WebKit/Source/core/html/TextControlElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 441 matching lines @@
     return VisiblePosition::firstPositionInNode(innerEditorElement());
   Position start, end;
   bool selected = Range::selectNodeContents(innerEditorElement(), start, end);
   if (!selected)
     return VisiblePosition();
   CharacterIterator it(start, end);
   it.advance(index - 1);
   return createVisiblePosition(it.endPosition(), TextAffinity::Upstream);
 }
 
+// TODO(yosin): We should move |TextControlElement::indexForVisiblePosition()|
+// to "AXLayoutObject.cpp" since this funciton is used only there.
 int TextControlElement::indexForVisiblePosition(
     const VisiblePosition& pos) const {
   Position indexPosition = pos.deepEquivalent().parentAnchoredEquivalent();
   if (enclosingTextControl(indexPosition) != this)
     return 0;
-  DCHECK(indexPosition.document());
-  Range* range = Range::create(*indexPosition.document());
-  range->setStart(innerEditorElement(), 0, ASSERT_NO_EXCEPTION);
-  range->setEnd(indexPosition.computeContainerNode(),
-                indexPosition.offsetInContainerNode(), ASSERT_NO_EXCEPTION);
-  return TextIterator::rangeLength(range->startPosition(),
-                                   range->endPosition());
+  DCHECK(indexPosition.isConnected()) << indexPosition;
+  return TextIterator::rangeLength(Position(innerEditorElement(), 0),
+                                   indexPosition);
 }
 
 unsigned TextControlElement::selectionStart() const {
   if (!isTextControl())
     return 0;
   if (document().focusedElement() != this)
     return m_cachedSelectionStart;
 
   return computeSelectionStart();
 }
@@ skipping 453 matching lines @@
 
 void TextControlElement::copyNonAttributePropertiesFromElement(
     const Element& source) {
   const TextControlElement& sourceElement =
       static_cast<const TextControlElement&>(source);
   m_lastChangeWasUserEdit = sourceElement.m_lastChangeWasUserEdit;
   HTMLFormControlElement::copyNonAttributePropertiesFromElement(source);
 }
 
 }  // namespace blink