Chromium Code Reviews
DescriptionRevert of Fix handling of device cloud signing policy key rotation (patchset #8 id:140001 of https://codereview.chromium.org/2558543003/ )
Reason for revert:
Broke KeyRotationDeviceCloudPolicyTest.Basic test
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/34579
Original issue's description:
> Fix handling of device cloud signing policy key rotation
>
> This CL fixes issues with handling of the signing key rotation for the
> device policy. There were some issues with not loading the updated
> owner key right after the new policy is stored. Even though the key
> would eventually be loaded thanks to the OwnerKeySet signal emitted
> by the session manager, there may be some window during which the old
> key is still used on the Chrome side.
>
> Also the CL adds a browser end-to-end test for browser policy key
> rotation (using a local policy test server). Some fake testing-only
> stubs were also fixed in order to support changing the signing keys
> (similar to how this is handled by the session manager).
>
> BUG=671659, 668716
> TEST=new browser test
>
> Review-Url: https://codereview.chromium.org/2558543003
> Cr-Commit-Position: refs/heads/master@{#454506}
> Committed: https://chromium.googlesource.com/chromium/src/+/6581fa97d9ac35a9c541856a0acc04c8be2cfc20
TBR=atwilson@chromium.org,mnissler@chromium.org,stevenjb@chromium.org,emaxx@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=671659, 668716
Review-Url: https://codereview.chromium.org/2727863004
Cr-Commit-Position: refs/heads/master@{#454541}
Committed: https://chromium.googlesource.com/chromium/src/+/3fa1b666a54ad027289ec0c1752fcfb6d138b512
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||