Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2727863004: Revert of Fix handling of device cloud signing policy key rotation (Closed)

Created:
3 years, 9 months ago by alph
Modified:
3 years, 9 months ago
CC:
chromium-reviews, hashimoto+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, Mattias Nissler (ping if slow)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix handling of device cloud signing policy key rotation (patchset #8 id:140001 of https://codereview.chromium.org/2558543003/ ) Reason for revert: Broke KeyRotationDeviceCloudPolicyTest.Basic test https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/34579 Original issue's description: > Fix handling of device cloud signing policy key rotation > > This CL fixes issues with handling of the signing key rotation for the > device policy. There were some issues with not loading the updated > owner key right after the new policy is stored. Even though the key > would eventually be loaded thanks to the OwnerKeySet signal emitted > by the session manager, there may be some window during which the old > key is still used on the Chrome side. > > Also the CL adds a browser end-to-end test for browser policy key > rotation (using a local policy test server). Some fake testing-only > stubs were also fixed in order to support changing the signing keys > (similar to how this is handled by the session manager). > > BUG=671659, 668716 > TEST=new browser test > > Review-Url: https://codereview.chromium.org/2558543003 > Cr-Commit-Position: refs/heads/master@{#454506} > Committed: https://chromium.googlesource.com/chromium/src/+/6581fa97d9ac35a9c541856a0acc04c8be2cfc20 TBR=atwilson@chromium.org,mnissler@chromium.org,stevenjb@chromium.org,emaxx@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=671659, 668716 Review-Url: https://codereview.chromium.org/2727863004 Cr-Commit-Position: refs/heads/master@{#454541} Committed: https://chromium.googlesource.com/chromium/src/+/3fa1b666a54ad027289ec0c1752fcfb6d138b512

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -243 lines) Patch
M chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc View 4 chunks +7 lines, -181 lines 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation.cc View 5 chunks +12 lines, -12 lines 0 comments Download
M chromeos/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/fake_session_manager_client.cc View 2 chunks +3 lines, -49 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
alph
Created Revert of Fix handling of device cloud signing policy key rotation
3 years, 9 months ago (2017-03-03 07:58:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727863004/1
3 years, 9 months ago (2017-03-03 07:58:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/3fa1b666a54ad027289ec0c1752fcfb6d138b512
3 years, 9 months ago (2017-03-03 08:00:04 UTC) #6
emaxx
3 years, 9 months ago (2017-03-03 18:32:48 UTC) #7
Message was sent while issue was closed.
alph@/others: Any ideas on why could the test fail on builders, but succeed when
running trybots from CL?
Are there any significant changes in the environment, or maybe with regard to
the the tests isolation?

Powered by Google App Engine
This is Rietveld 408576698