Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Unified Diff: chrome/browser/chromeos/settings/session_manager_operation.cc

Issue 2727863004: Revert of Fix handling of device cloud signing policy key rotation (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc ('k') | chromeos/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/settings/session_manager_operation.cc
diff --git a/chrome/browser/chromeos/settings/session_manager_operation.cc b/chrome/browser/chromeos/settings/session_manager_operation.cc
index 64db533a82372e60e72b69293e5f46e5813be0e2..bfe8316c87e30cb90f995b6934152ddfec25c6e7 100644
--- a/chrome/browser/chromeos/settings/session_manager_operation.cc
+++ b/chrome/browser/chromeos/settings/session_manager_operation.cc
@@ -46,7 +46,7 @@
void SessionManagerOperation::RestartLoad(bool key_changed) {
if (key_changed)
- public_key_ = nullptr;
+ public_key_ = NULL;
if (!is_loading_)
return;
@@ -76,17 +76,20 @@
}
void SessionManagerOperation::EnsurePublicKey(const base::Closure& callback) {
- if (force_key_load_ || !public_key_ || !public_key_->is_loaded()) {
+ if (force_key_load_ || !public_key_.get() || !public_key_->is_loaded()) {
scoped_refptr<base::TaskRunner> task_runner =
content::BrowserThread::GetBlockingPool()
->GetTaskRunnerWithShutdownBehavior(
base::SequencedWorkerPool::SKIP_ON_SHUTDOWN);
base::PostTaskAndReplyWithResult(
- task_runner.get(), FROM_HERE,
- base::Bind(&SessionManagerOperation::LoadPublicKey, owner_key_util_,
- force_key_load_ ? nullptr : public_key_),
+ task_runner.get(),
+ FROM_HERE,
+ base::Bind(&SessionManagerOperation::LoadPublicKey,
+ owner_key_util_,
+ public_key_),
base::Bind(&SessionManagerOperation::StorePublicKey,
- weak_factory_.GetWeakPtr(), callback));
+ weak_factory_.GetWeakPtr(),
+ callback));
} else {
callback.Run();
}
@@ -99,7 +102,7 @@
scoped_refptr<PublicKey> public_key(new PublicKey());
// Keep already-existing public key.
- if (current_key && current_key->is_loaded()) {
+ if (current_key.get() && current_key->is_loaded()) {
public_key->data() = current_key->data();
}
if (!public_key->is_loaded() && util->IsPublicKeyPresent()) {
@@ -115,7 +118,7 @@
force_key_load_ = false;
public_key_ = new_key;
- if (!public_key_ || !public_key_->is_loaded()) {
+ if (!public_key_.get() || !public_key_->is_loaded()) {
ReportResult(DeviceSettingsService::STORE_KEY_UNAVAILABLE);
return;
}
@@ -233,10 +236,7 @@
std::unique_ptr<em::PolicyFetchResponse> policy)
: SessionManagerOperation(callback),
policy_(std::move(policy)),
- weak_factory_(this) {
- if (policy_->has_new_public_key())
- force_key_load_ = true;
-}
+ weak_factory_(this) {}
StoreSettingsOperation::~StoreSettingsOperation() {}
« no previous file with comments | « chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc ('k') | chromeos/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698