Create ChromeAutofillClient in SimpleWebViewDialog

Create ChromeAutofillClient in SimpleWebViewDialog

This prevents a crash when a Form-Not-Secure warning is shown on a
ChromeOS captive portal login page.

BUG=698438

[estark, 2017-03-04 01:26:34]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-04 01:26:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2017-03-04 01:28:45]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-04 01:29:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-04 01:49:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-04 01:49:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[estark, 2017-03-04 01:56:38]

Description was changed from

==========
Create ChromeAutofillClient in SimpleWebViewDialog

BUG=698438
==========

to

==========
Create ChromeAutofillClient in SimpleWebViewDialog

This prevents a crash when a Form-Not-Secure warning is shown on a
ChromeOS captive portal login page.

BUG=698438
==========

[estark, 2017-03-04 02:51:27]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-04 02:51:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2017-03-04 02:52:25]

estark@chromium.org changed reviewers:
+ meacer@chromium.org

[estark, 2017-03-04 02:52:26]

meacer PTAL before I send to owners? Thanks!

[commit-bot: I haz the power, 2017-03-04 03:31:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-04 03:32:00]

Dry run: This issue passed the CQ dry run.

[meacer, 2017-03-04 05:54:15]

Lgtm with a question

https://codereview.chromium.org/2727813006/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/ui/simple_web_view_dialog_browsertest.cc
(right):

https://codereview.chromium.org/2727813006/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/ui/simple_web_view_dialog_browsertest.cc:64:
SimpleWebViewDialog* GetSimpleWebViewDialog(CaptivePortalWindowProxy* proxy) {
const method

https://codereview.chromium.org/2727813006/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/ui/simple_web_view_dialog_browsertest.cc:69:
SimpleWebViewDialog* dialog) {
const method

https://codereview.chromium.org/2727813006/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/ui/simple_web_view_dialog_browsertest.cc:105:
driver->ShowNotSecureWarning(base::i18n::LEFT_TO_RIGHT, gfx::RectF(0, 0));
Would it make sense to change this test or add a new one to simulate a form with
password field and check that the form not secure warning and the not secure
chip is shown?

[meacer, 2017-03-06 21:10:23]

https://codereview.chromium.org/2727813006/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc (right):

https://codereview.chromium.org/2727813006/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc:159:
autofill::ChromeAutofillClient::CreateForWebContents(web_contents);
On closer look, I think this fix is incomplete. It fixes the immediate crash,
but there is another crash:
- Click the username or password form. The "login not secure" autofill entry
shows.
- Move mouse over this entry. Chrome crashes.

This is because autofill_driver is null in
ContentPasswordManagerDriver::GetAutofillAgent(). In order to fix that, you'll
need to create it here as well:


autofill::ChromeAutofillClient::CreateForWebContents(
    web_view_->web_contents());
autofill::ChromeAutofillClient* autofill_client =
    autofill::ChromeAutofillClient::FromWebContents(web_contents);
autofill::ContentAutofillDriverFactory::CreateForWebContentsAndDelegate(web_contents,
    autofill_client, g_browser_process->GetApplicationLocale(),
    autofill::AutofillManager::ENABLE_AUTOFILL_DOWNLOAD_MANAGER);

This is why I was asking about a browser test that clicks around :)