Create ChromeAutofillClient in SimpleWebViewDialog

chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc

Index: chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc
diff --git a/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc b/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc
index ec4cdc7f2b06f66d80fb5f485a168fd90abeb00a..e0c97ede9043e832e3acb6879d50eb0d2f3c061b 100644
--- a/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc
+++ b/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc
@@ -156,6 +156,7 @@ void SimpleWebViewDialog::StartLoad(const GURL& url) {
   DCHECK(web_contents);
 
   // Create the password manager that is needed for the proxy.
+  autofill::ChromeAutofillClient::CreateForWebContents(web_contents);

[meacer, 2017/03/06 21:10:23]

On closer look, I think this fix is incomplete. It fixes the immediate crash,
but there is another crash:
- Click the username or password form. The "login not secure" autofill entry
shows.
- Move mouse over this entry. Chrome crashes.

This is because autofill_driver is null in
ContentPasswordManagerDriver::GetAutofillAgent(). In order to fix that, you'll
need to create it here as well:


autofill::ChromeAutofillClient::CreateForWebContents(
    web_view_->web_contents());
autofill::ChromeAutofillClient* autofill_client =
    autofill::ChromeAutofillClient::FromWebContents(web_contents);
autofill::ContentAutofillDriverFactory::CreateForWebContentsAndDelegate(web_contents,
    autofill_client, g_browser_process->GetApplicationLocale(),
    autofill::AutofillManager::ENABLE_AUTOFILL_DOWNLOAD_MANAGER);

This is why I was asking about a browser test that clicks around :)

   ChromePasswordManagerClient::CreateForWebContentsWithAutofillClient(
       web_contents,
       autofill::ChromeAutofillClient::FromWebContents(web_contents));