Create ChromeAutofillClient in SimpleWebViewDialog

chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/ui/simple_web_view_dialog.h"
 
 #include "ash/public/cpp/shell_window_ids.h"
 #include "ash/shell.h"
 #include "base/macros.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 138 matching lines @@
     web_view_container_.reset(new views::WebView(profile_));
   web_view_ = web_view_container_.get();
   web_view_->set_owned_by_client();
   web_view_->GetWebContents()->SetDelegate(this);
   web_view_->LoadInitialURL(url);
 
   WebContents* web_contents = web_view_->GetWebContents();
   DCHECK(web_contents);
 
   // Create the password manager that is needed for the proxy.
+  autofill::ChromeAutofillClient::CreateForWebContents(web_contents);

[meacer, 2017/03/06 21:10:23]

On closer look, I think this fix is incomplete. It fixes the immediate crash,
but there is another crash:
- Click the username or password form. The "login not secure" autofill entry
shows.
- Move mouse over this entry. Chrome crashes.

This is because autofill_driver is null in
ContentPasswordManagerDriver::GetAutofillAgent(). In order to fix that, you'll
need to create it here as well:


autofill::ChromeAutofillClient::CreateForWebContents(
    web_view_->web_contents());
autofill::ChromeAutofillClient* autofill_client =
    autofill::ChromeAutofillClient::FromWebContents(web_contents);
autofill::ContentAutofillDriverFactory::CreateForWebContentsAndDelegate(web_contents,
    autofill_client, g_browser_process->GetApplicationLocale(),
    autofill::AutofillManager::ENABLE_AUTOFILL_DOWNLOAD_MANAGER);

This is why I was asking about a browser test that clicks around :)

   ChromePasswordManagerClient::CreateForWebContentsWithAutofillClient(
       web_contents,
       autofill::ChromeAutofillClient::FromWebContents(web_contents));
 }
 
 void SimpleWebViewDialog::Init() {
   // Create the security state model that the toolbar model needs.
   if (web_view_->GetWebContents())
     SecurityStateTabHelper::CreateForWebContents(web_view_->GetWebContents());
   toolbar_model_.reset(
@@ skipping 211 matching lines @@
 
 void SimpleWebViewDialog::UpdateReload(bool is_loading, bool force) {
   if (reload_) {
     reload_->ChangeMode(
         is_loading ? ReloadButton::MODE_STOP : ReloadButton::MODE_RELOAD,
         force);
   }
 }
 
 }  // namespace chromeos