Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2727583006: Timeline: fix NPE when hovering over Interactions strip (Closed)

Created:
3 years, 9 months ago by caseq
Modified:
3 years, 9 months ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Timeline: fix NPE when hovering over Interactions strip BUG=698106 Review-Url: https://codereview.chromium.org/2727583006 Cr-Commit-Position: refs/heads/master@{#454502} Committed: https://chromium.googlesource.com/chromium/src/+/6c9e50b3b25885f6e7c638a7edab2a0c731c46a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
caseq
3 years, 9 months ago (2017-03-03 01:27:13 UTC) #2
alph
lgtm
3 years, 9 months ago (2017-03-03 01:30:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727583006/1
3 years, 9 months ago (2017-03-03 01:31:03 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 03:27:36 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6c9e50b3b25885f6e7c638a7edab...

Powered by Google App Engine
This is Rietveld 408576698