Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 2727583006: Timeline: fix NPE when hovering over Interactions strip (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js
index 42aad625090028d17eff7ee412c983b23c0d2c77..356dd8ecb37d8d62e3fa297e4c837e3de903d486 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js
@@ -497,9 +497,9 @@ Timeline.TimelineFlameChartDataProvider = class {
*/
highlightEntry(entryIndex) {
SDK.DOMModel.hideDOMNodeHighlight();
- var event = /** @type {!SDK.TracingModel.Event} */ (this._entryData[entryIndex]);
- if (!event)
+ if (this._entryType(entryIndex) !== Timeline.TimelineFlameChartEntryType.Event)
return;
+ var event = /** @type {!SDK.TracingModel.Event} */ (this._entryData[entryIndex]);
var target = this._model.targetByEvent(event);
if (!target)
return;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698