Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2727503002: Revert of Make --headless flag work on Mac (Closed)

Created:
3 years, 9 months ago by dvallet
Modified:
3 years, 9 months ago
Reviewers:
Sam McNally, Sami, sky
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make --headless flag work on Mac (patchset #2 id:20001 of https://codereview.chromium.org/2720863003/ ) Reason for revert: This CL is braking Mac buildbot, when trying to build headless_example and headless_shell with component build set to false. With the following error: AILED: headless_example headless_example.unstripped export DEVELOPER_DIR=/b/c/b/mac/src/build/mac_files/Xcode.app; TOOL_VERSION=1487140455 ../../build/toolchain/mac/linker_driver.py ../../third_party/llvm-build/Release+Asserts/bin/clang++ -stdlib=libc++ -arch x86_64 -Wcrl,unstripped,/b/c/b/mac/src/out/Release -Werror -Wl,-dead_strip -isysroot /b/c/b/mac/src/build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -mmacosx-version-min=10.9 -Wl,-ObjC -Wl,-pie -Wcrl,strip,-x,-S -L../../build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/lib -o "./headless_example" -Wl,-filelist,"./headless_example.rsp" -lbsm -framework Cocoa -framework Foundation -framework IOKit -framework Security -framework SystemConfiguration -framework ApplicationServices -framework AppKit -framework CoreFoundation -framework CoreGraphics -framework CoreText -framework CFNetwork -framework CoreServices -lresolv -framework IOBluetooth -framework Accelerate -framework AudioUnit -framework Carbon -framework CoreVideo -framework IOSurface -framework OpenGL -framework Quartz -framework QuartzCore -framework AVFoundation -framework CoreMedia -framework AudioToolbox -framework CoreAudio -framework VideoToolbox -framework DiskArbitration -framework CoreMIDI -lsandbox -framework GameController -framework CoreWLAN -lcups Undefined symbols for architecture x86_64: "content::PpapiPluginMain(content::MainFunctionParams const&)", referenced from: content::RunNamedProcessTypeMain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*)::kMainFunctions in content_main_runner.o "content::PpapiBrokerMain(content::MainFunctionParams const&)", referenced from: content::RunNamedProcessTypeMain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*)::kMainFunctions in content_main_runner.o ld: symbol(s) not found for architecture x86_64 Original issue's description: > Make --headless flag work on Mac > > > BUG=687407 > > Review-Url: https://codereview.chromium.org/2720863003 > Cr-Commit-Position: refs/heads/master@{#453778} > Committed: https://chromium.googlesource.com/chromium/src/+/664dcbac5d9fac9223b5e273e30ee094d91489b3 TBR=skyostil@chromium.org,sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=687407 Review-Url: https://codereview.chromium.org/2727503002 Cr-Commit-Position: refs/heads/master@{#453792} Committed: https://chromium.googlesource.com/chromium/src/+/f1cdf374afee0df705c899ae71ec3970915f9512

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -14 lines) Patch
M chrome/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/chrome_main.cc View 2 chunks +3 lines, -11 lines 0 comments Download
M headless/lib/browser/headless_content_browser_client.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
dvallet
Created Revert of Make --headless flag work on Mac
3 years, 9 months ago (2017-03-01 01:56:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727503002/1
3 years, 9 months ago (2017-03-01 01:56:54 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 9 months ago (2017-03-01 01:56:56 UTC) #5
dvallet
3 years, 9 months ago (2017-03-01 01:58:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727503002/1
3 years, 9 months ago (2017-03-01 02:01:12 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 9 months ago (2017-03-01 02:01:13 UTC) #10
Sam McNally
lgtm
3 years, 9 months ago (2017-03-01 02:02:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727503002/1
3 years, 9 months ago (2017-03-01 02:04:03 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 02:05:59 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f1cdf374afee0df705c899ae71ec...

Powered by Google App Engine
This is Rietveld 408576698