Make --headless flag work on Mac

Make --headless flag work on Mac


BUG=687407
Review-Url: https://codereview.chromium.org/2720863003
Cr-Commit-Position: refs/heads/master@{#453778}
Committed: https://chromium.googlesource.com/chromium/src/+/664dcbac5d9fac9223b5e273e30ee094d91489b3

[dvallet, 2017-02-27 23:54:47]

The CQ bit was checked by dvallet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 23:55:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 01:18:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 01:18:58]

Dry run: This issue passed the CQ dry run.

[dvallet, 2017-02-28 02:08:35]

dvallet@chromium.org changed reviewers:
+ sky@chromium.org, skyostil@chromium.org

[dvallet, 2017-02-28 02:08:36]

skyostil@chromium.org: Please review changes in headless/

sky@chromium.org: Please review changes in chrome/

[sky, 2017-02-28 04:10:27]

LGTM with minor changes below.

https://codereview.chromium.org/2720863003/diff/1/chrome/BUILD.gn
File chrome/BUILD.gn (right):

https://codereview.chromium.org/2720863003/diff/1/chrome/BUILD.gn#newcode985
chrome/BUILD.gn:985: # For headless mode.
The name of the directory implies it's for headless, so please remove the
comment and move the directory in with the rest above.

https://codereview.chromium.org/2720863003/diff/1/chrome/app/chrome_main.cc
File chrome/app/chrome_main.cc (right):

https://codereview.chromium.org/2720863003/diff/1/chrome/app/chrome_main.cc#n...
chrome/app/chrome_main.cc:101: if
(command_line->HasSwitch(switches::kHeadless)){
space between ')' and '{'.

[dvallet, 2017-02-28 04:55:55]

Thanks for the review!

https://codereview.chromium.org/2720863003/diff/1/chrome/BUILD.gn
File chrome/BUILD.gn (right):

https://codereview.chromium.org/2720863003/diff/1/chrome/BUILD.gn#newcode985
chrome/BUILD.gn:985: # For headless mode.
On 2017/02/28 04:10:27, sky wrote:
> The name of the directory implies it's for headless, so please remove the
> comment and move the directory in with the rest above.

Done.

https://codereview.chromium.org/2720863003/diff/1/chrome/app/chrome_main.cc
File chrome/app/chrome_main.cc (right):

https://codereview.chromium.org/2720863003/diff/1/chrome/app/chrome_main.cc#n...
chrome/app/chrome_main.cc:101: if
(command_line->HasSwitch(switches::kHeadless)){
On 2017/02/28 04:10:27, sky wrote:
> space between ')' and '{'.

Done.

[Sami, 2017-02-28 16:09:25]

lgtm, thanks!

nit: one 's' missing from patch description.

[dvallet, 2017-02-28 22:26:09]

Description was changed from

==========
Make --headles flag work on Mac


BUG=687407
==========

to

==========
Make --headless flag work on Mac


BUG=687407
==========

[dvallet, 2017-02-28 22:26:15]

The CQ bit was checked by dvallet@chromium.org

[dvallet, 2017-02-28 22:26:16]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2720863003/#ps20001
(title: "nit  headless_shell_lib dependency")

[commit-bot: I haz the power, 2017-02-28 22:26:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 23:04:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 23:04:01]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[dvallet, 2017-02-28 23:07:17]

The CQ bit was checked by dvallet@chromium.org

[commit-bot: I haz the power, 2017-02-28 23:08:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 00:47:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488323237869770,
"parent_rev": "333a6dee3c08b91580f27ab196288bb7cdb21fdb", "commit_rev":
"664dcbac5d9fac9223b5e273e30ee094d91489b3"}

[commit-bot: I haz the power, 2017-03-01 00:48:01]

Description was changed from

==========
Make --headless flag work on Mac


BUG=687407
==========

to

==========
Make --headless flag work on Mac


BUG=687407

Review-Url: https://codereview.chromium.org/2720863003
Cr-Commit-Position: refs/heads/master@{#453778}
Committed:
https://chromium.googlesource.com/chromium/src/+/664dcbac5d9fac9223b5e273e30e...
==========

[commit-bot: I haz the power, 2017-03-01 00:48:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/664dcbac5d9fac9223b5e273e30e...

[dvallet, 2017-03-01 01:56:23]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2727503002/ by dvallet@chromium.org.

The reason for reverting is: This CL is braking Mac buildbot, when trying to
build headless_example and headless_shell with component build set to false.
With the following error: 
AILED: headless_example headless_example.unstripped 
export DEVELOPER_DIR=/b/c/b/mac/src/build/mac_files/Xcode.app; 
TOOL_VERSION=1487140455 ../../build/toolchain/mac/linker_driver.py
../../third_party/llvm-build/Release+Asserts/bin/clang++  -stdlib=libc++ -arch
x86_64 -Wcrl,unstripped,/b/c/b/mac/src/out/Release -Werror -Wl,-dead_strip
-isysroot
/b/c/b/mac/src/build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk
-mmacosx-version-min=10.9 -Wl,-ObjC -Wl,-pie -Wcrl,strip,-x,-S
-L../../build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/lib
-o "./headless_example" -Wl,-filelist,"./headless_example.rsp"  -lbsm -framework
Cocoa -framework Foundation -framework IOKit -framework Security -framework
SystemConfiguration -framework ApplicationServices -framework AppKit -framework
CoreFoundation -framework CoreGraphics -framework CoreText -framework CFNetwork
-framework CoreServices -lresolv -framework IOBluetooth -framework Accelerate
-framework AudioUnit -framework Carbon -framework CoreVideo -framework IOSurface
-framework OpenGL -framework Quartz -framework QuartzCore -framework
AVFoundation -framework CoreMedia -framework AudioToolbox -framework CoreAudio
-framework VideoToolbox -framework DiskArbitration -framework CoreMIDI -lsandbox
-framework GameController -framework CoreWLAN -lcups
Undefined symbols for architecture x86_64:
  "content::PpapiPluginMain(content::MainFunctionParams const&)", referenced
from:
      content::RunNamedProcessTypeMain(std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char> > const&,
content::MainFunctionParams const&,
content::ContentMainDelegate*)::kMainFunctions in content_main_runner.o
  "content::PpapiBrokerMain(content::MainFunctionParams const&)", referenced
from:
      content::RunNamedProcessTypeMain(std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char> > const&,
content::MainFunctionParams const&,
content::ContentMainDelegate*)::kMainFunctions in content_main_runner.o
ld: symbol(s) not found for architecture x86_64.

[dvallet, 2017-03-01 04:03:59]

Patchset #3 (id:40001) has been deleted