Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 2727443002: [GN] Update visual_studio_writer to use SDK kit 14393 instead of 10586. (Closed)

Created:
3 years, 9 months ago by penny
Modified:
3 years, 9 months ago
Reviewers:
brettw, brucedawson
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GN] Update visual_studio_writer to use SDK kit 14393 instead of 10586. Every vcxproj file gets generated with AdditionalIncludeDirectories set to this. Affects intellisense, etc. R=brucedawson@chromium.org,brettw@chromium.org BUG= Review-Url: https://codereview.chromium.org/2727443002 Cr-Commit-Position: refs/heads/master@{#453796} Committed: https://chromium.googlesource.com/chromium/src/+/f8d29f02e8216bfcfcf4f3146189d92f2565cb31

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gn/visual_studio_writer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
penny
Hi Brett, Super small change to fix vcxproj files generated. Would be better to perhaps ...
3 years, 9 months ago (2017-02-28 22:54:36 UTC) #1
brettw
lgtm
3 years, 9 months ago (2017-02-28 23:46:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727443002/1
3 years, 9 months ago (2017-02-28 23:51:00 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/399759)
3 years, 9 months ago (2017-03-01 00:05:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727443002/1
3 years, 9 months ago (2017-03-01 00:08:11 UTC) #8
brucedawson
Two spaces after a period in the change description? What madness is this? Other than ...
3 years, 9 months ago (2017-03-01 00:13:41 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 02:48:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f8d29f02e8216bfcfcf4f3146189...

Powered by Google App Engine
This is Rietveld 408576698