Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Side by Side Diff: tools/gn/visual_studio_writer.cc

Issue 2727443002: [GN] Update visual_studio_writer to use SDK kit 14393 instead of 10586. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "tools/gn/visual_studio_writer.h" 5 #include "tools/gn/visual_studio_writer.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <iterator> 8 #include <iterator>
9 #include <map> 9 #include <map>
10 #include <memory> 10 #include <memory>
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 const SourceFile& source_file_; 69 const SourceFile& source_file_;
70 }; 70 };
71 71
72 const char kToolsetVersionVs2013[] = "v120"; // Visual Studio 2013 72 const char kToolsetVersionVs2013[] = "v120"; // Visual Studio 2013
73 const char kToolsetVersionVs2015[] = "v140"; // Visual Studio 2015 73 const char kToolsetVersionVs2015[] = "v140"; // Visual Studio 2015
74 const char kProjectVersionVs2013[] = "12.0"; // Visual Studio 2013 74 const char kProjectVersionVs2013[] = "12.0"; // Visual Studio 2013
75 const char kProjectVersionVs2015[] = "14.0"; // Visual Studio 2015 75 const char kProjectVersionVs2015[] = "14.0"; // Visual Studio 2015
76 const char kVersionStringVs2013[] = "Visual Studio 2013"; // Visual Studio 2013 76 const char kVersionStringVs2013[] = "Visual Studio 2013"; // Visual Studio 2013
77 const char kVersionStringVs2015[] = "Visual Studio 2015"; // Visual Studio 2015 77 const char kVersionStringVs2015[] = "Visual Studio 2015"; // Visual Studio 2015
78 const char kWindowsKitsVersion[] = "10"; // Windows 10 SDK 78 const char kWindowsKitsVersion[] = "10"; // Windows 10 SDK
79 const char kWindowsKitsIncludeVersion[] = "10.0.10586.0"; // Windows 10 SDK 79 const char kWindowsKitsIncludeVersion[] = "10.0.14393.0"; // Windows 10 SDK
80 80
81 const char kGuidTypeProject[] = "{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}"; 81 const char kGuidTypeProject[] = "{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}";
82 const char kGuidTypeFolder[] = "{2150E333-8FDC-42A3-9474-1A3956D46DE8}"; 82 const char kGuidTypeFolder[] = "{2150E333-8FDC-42A3-9474-1A3956D46DE8}";
83 const char kGuidSeedProject[] = "project"; 83 const char kGuidSeedProject[] = "project";
84 const char kGuidSeedFolder[] = "folder"; 84 const char kGuidSeedFolder[] = "folder";
85 const char kGuidSeedFilter[] = "filter"; 85 const char kGuidSeedFilter[] = "filter";
86 86
87 const char kConfigurationName[] = "GN"; 87 const char kConfigurationName[] = "GN";
88 88
89 std::string GetWindowsKitsIncludeDirs() { 89 std::string GetWindowsKitsIncludeDirs() {
(...skipping 769 matching lines...) Expand 10 before | Expand all | Expand 10 after
859 } 859 }
860 } 860 }
861 861
862 std::string VisualStudioWriter::GetNinjaTarget(const Target* target) { 862 std::string VisualStudioWriter::GetNinjaTarget(const Target* target) {
863 std::ostringstream ninja_target_out; 863 std::ostringstream ninja_target_out;
864 DCHECK(!target->dependency_output_file().value().empty()); 864 DCHECK(!target->dependency_output_file().value().empty());
865 ninja_path_output_.WriteFile(ninja_target_out, 865 ninja_path_output_.WriteFile(ninja_target_out,
866 target->dependency_output_file()); 866 target->dependency_output_file());
867 return ninja_target_out.str(); 867 return ninja_target_out.str();
868 } 868 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698