Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/SafeBrowsingTest.java

Issue 2727363002: Remove unnecessary stuff from SafeBrowsingTest (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/javatests/src/org/chromium/android_webview/test/SafeBrowsingTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/SafeBrowsingTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/SafeBrowsingTest.java
index 4ec94474d4ccb21a7573abcd364d23fde1325bce..741eb9aeaefb661c961370cc7c038a0e4c594c95 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/SafeBrowsingTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/SafeBrowsingTest.java
@@ -27,8 +27,6 @@ import org.chromium.components.safe_browsing.SafeBrowsingApiHandler;
import org.chromium.content_public.browser.WebContents;
import org.chromium.net.test.EmbeddedTestServer;
-import java.util.concurrent.TimeUnit;
-
/**
* Test suite for SafeBrowsing.
*
@@ -270,7 +268,7 @@ public class SafeBrowsingTest extends AwTestBase {
OnReceivedError2Helper errorHelper = mContentsClient.getOnReceivedError2Helper();
int errorCount = errorHelper.getCallCount();
dontProceedThroughInterstitial();
- errorHelper.waitForCallback(errorCount, 1, WAIT_TIMEOUT_MS, TimeUnit.MILLISECONDS);
+ errorHelper.waitForCallback(errorCount);
assertEquals(ErrorCodeConversionHelper.ERROR_UNKNOWN, errorHelper.getError().errorCode);
assertEquals(responseUrl, errorHelper.getRequest().url);
}
@@ -288,7 +286,7 @@ public class SafeBrowsingTest extends AwTestBase {
OnReceivedError2Helper errorHelper = mContentsClient.getOnReceivedError2Helper();
int errorCount = errorHelper.getCallCount();
dontProceedThroughInterstitial();
- errorHelper.waitForCallback(errorCount, 1, WAIT_TIMEOUT_MS, TimeUnit.MILLISECONDS);
+ errorHelper.waitForCallback(errorCount);
assertEquals(ErrorCodeConversionHelper.ERROR_UNKNOWN, errorHelper.getError().errorCode);
final String subresourceUrl = mTestServer.getURL(MALWARE_HTML_PATH);
assertEquals(subresourceUrl, errorHelper.getRequest().url);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698