Chromium Code Reviews
DescriptionReland of Bug Fix: List Too Small When Sharing Tab Only (patchset #1 id:1 of https://codereview.chromium.org/2731573002/ )
Reason for revert:
Let's do the fix
Original issue's description:
> Revert of Bug Fix: List Too Small When Sharing Tab Only (patchset #3 id:40001 of https://codereview.chromium.org/2725833003/ )
>
> Reason for revert:
> A coding style issue
>
> Original issue's description:
> > Bug Fix: List Too Small When Sharing Tab Only
> >
> > When the javascript only includes "tab" as source, the source list is too small, and thus inconvenient for users to pick.
> >
> > The reason is that we preset the height too small.
> >
> > In this CL we preset the height larger to a reasonable value.
> >
> > BUG=697516
> >
> > Review-Url: https://codereview.chromium.org/2725833003
> > Cr-Commit-Position: refs/heads/master@{#454317}
> > Committed: https://chromium.googlesource.com/chromium/src/+/866596040a23db3ab4152dba1d41f0a574fc2b83
>
> TBR=msw@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=697516
>
> Review-Url: https://codereview.chromium.org/2731573002
> Cr-Commit-Position: refs/heads/master@{#454322}
> Committed: https://chromium.googlesource.com/chromium/src/+/ba4aa7372b68295d0ba4001557e82063c1d90d87
TBR=msw@chromium.org
BUG=697516
Review-Url: https://codereview.chromium.org/2727333002
Cr-Commit-Position: refs/heads/master@{#454359}
Committed: https://chromium.googlesource.com/chromium/src/+/7af696b5a11fcbdae617d237dbc06aaca6807f94
Patch Set 1 #Patch Set 2 : Reland #Messages
Total messages: 8 (4 generated)
|