Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2727333002: Reland of Bug Fix: List Too Small When Sharing Tab Only (Closed)

Created:
3 years, 9 months ago by qiangchen
Modified:
3 years, 9 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Bug Fix: List Too Small When Sharing Tab Only (patchset #1 id:1 of https://codereview.chromium.org/2731573002/ ) Reason for revert: Let's do the fix Original issue's description: > Revert of Bug Fix: List Too Small When Sharing Tab Only (patchset #3 id:40001 of https://codereview.chromium.org/2725833003/ ) > > Reason for revert: > A coding style issue > > Original issue's description: > > Bug Fix: List Too Small When Sharing Tab Only > > > > When the javascript only includes "tab" as source, the source list is too small, and thus inconvenient for users to pick. > > > > The reason is that we preset the height too small. > > > > In this CL we preset the height larger to a reasonable value. > > > > BUG=697516 > > > > Review-Url: https://codereview.chromium.org/2725833003 > > Cr-Commit-Position: refs/heads/master@{#454317} > > Committed: https://chromium.googlesource.com/chromium/src/+/866596040a23db3ab4152dba1d41f0a574fc2b83 > > TBR=msw@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=697516 > > Review-Url: https://codereview.chromium.org/2731573002 > Cr-Commit-Position: refs/heads/master@{#454322} > Committed: https://chromium.googlesource.com/chromium/src/+/ba4aa7372b68295d0ba4001557e82063c1d90d87 TBR=msw@chromium.org BUG=697516 Review-Url: https://codereview.chromium.org/2727333002 Cr-Commit-Position: refs/heads/master@{#454359} Committed: https://chromium.googlesource.com/chromium/src/+/7af696b5a11fcbdae617d237dbc06aaca6807f94

Patch Set 1 #

Patch Set 2 : Reland #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
qiangchen
Created Reland of Bug Fix: List Too Small When Sharing Tab Only
3 years, 9 months ago (2017-03-02 18:59:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727333002/40001
3 years, 9 months ago (2017-03-02 19:04:23 UTC) #4
msw
lgtm; it also would have been fine to just spin up another cl that removed ...
3 years, 9 months ago (2017-03-02 19:06:26 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 20:09:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7af696b5a11fcbdae617d237dbc0...

Powered by Google App Engine
This is Rietveld 408576698