Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2731573002: Revert of Bug Fix: List Too Small When Sharing Tab Only (Closed)

Created:
3 years, 9 months ago by qiangchen
Modified:
3 years, 9 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Bug Fix: List Too Small When Sharing Tab Only (patchset #3 id:40001 of https://codereview.chromium.org/2725833003/ ) Reason for revert: A coding style issue Original issue's description: > Bug Fix: List Too Small When Sharing Tab Only > > When the javascript only includes "tab" as source, the source list is too small, and thus inconvenient for users to pick. > > The reason is that we preset the height too small. > > In this CL we preset the height larger to a reasonable value. > > BUG=697516 > > Review-Url: https://codereview.chromium.org/2725833003 > Cr-Commit-Position: refs/heads/master@{#454317} > Committed: https://chromium.googlesource.com/chromium/src/+/866596040a23db3ab4152dba1d41f0a574fc2b83 TBR=msw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=697516 Review-Url: https://codereview.chromium.org/2731573002 Cr-Commit-Position: refs/heads/master@{#454322} Committed: https://chromium.googlesource.com/chromium/src/+/ba4aa7372b68295d0ba4001557e82063c1d90d87

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
qiangchen
Created Revert of Bug Fix: List Too Small When Sharing Tab Only
3 years, 9 months ago (2017-03-02 18:52:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731573002/1
3 years, 9 months ago (2017-03-02 18:53:23 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ba4aa7372b68295d0ba4001557e82063c1d90d87
3 years, 9 months ago (2017-03-02 18:54:42 UTC) #6
qiangchen
3 years, 9 months ago (2017-03-02 18:59:26 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2727333002/ by qiangchen@chromium.org.

The reason for reverting is: Let's do the fix.

Powered by Google App Engine
This is Rietveld 408576698