Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2727263003:
[LayoutNG] Fix orthogonal writing mode with abs/fixed descendants. (Closed)
|
Created:
3 years, 9 months ago by ikilpatrick Modified:
3 years, 9 months ago CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[LayoutNG] Fix orthogonal writing mode with abs/fixed descendants.
The current code was mixing up the block_estimate between
descendant/container writing modes. It keeps it now in the child's
writing mode.
BUG=635619
Review-Url: https://codereview.chromium.org/2727263003
Cr-Commit-Position: refs/heads/master@{#454517}
Committed: https://chromium.googlesource.com/chromium/src/+/c31e3e5a55e1bc3a719c7012ca0d9bff6ba2ba51
Patch Set 1 #Patch Set 2 : fix. #Patch Set 3 : fix comment. #
Total comments: 2
Messages
Total messages: 26 (16 generated)
The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run
ikilpatrick@chromium.org changed reviewers: + atotic@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm Thanks for catching this.
The CQ bit was unchecked by ikilpatrick@chromium.org
The CQ bit was checked by ikilpatrick@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
ikilpatrick@chromium.org changed reviewers: + eae@chromium.org
glebl@chromium.org changed reviewers: + glebl@chromium.org
The CQ bit was checked by glebl@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488515343878360,
"parent_rev": "22e8735948a7c60d393250be79c9959d218faafe", "commit_rev":
"c31e3e5a55e1bc3a719c7012ca0d9bff6ba2ba51"}
Message was sent while issue was closed.
Description was changed from ========== [LayoutNG] Fix orthogonal writing mode with abs/fixed descendants. The current code was mixing up the block_estimate between descendant/container writing modes. It keeps it now in the child's writing mode. BUG=635619 ========== to ========== [LayoutNG] Fix orthogonal writing mode with abs/fixed descendants. The current code was mixing up the block_estimate between descendant/container writing modes. It keeps it now in the child's writing mode. BUG=635619 Review-Url: https://codereview.chromium.org/2727263003 Cr-Commit-Position: refs/heads/master@{#454517} Committed: https://chromium.googlesource.com/chromium/src/+/c31e3e5a55e1bc3a719c7012ca0d... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/c31e3e5a55e1bc3a719c7012ca0d...
Message was sent while issue was closed.
cbiesinger@chromium.org changed reviewers: + cbiesinger@chromium.org
Message was sent while issue was closed.
lgtm but see comment below, could you fix that in a separate cl? https://codereview.chromium.org/2727263003/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc (right): https://codereview.chromium.org/2727263003/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc:181: NGLogicalSize available_size{inline_size, block_size}; You have a variable logical_available_size and an available_size, which is also a logical size, and they're different :/ can you rename one of them?
Message was sent while issue was closed.
https://codereview.chromium.org/2727263003/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc (right): https://codereview.chromium.org/2727263003/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc:181: NGLogicalSize available_size{inline_size, block_size}; On 2017/03/03 12:58:49, cbiesinger wrote: > You have a variable logical_available_size and an available_size, which is also > a logical size, and they're different :/ can you rename one of them? Sent, thanks for picking up on this. :) |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
