Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2727203003: Revert of Make SelectionPopupController.ShowPastePopup only be triggered by Blink (Closed)

Created:
3 years, 9 months ago by amaralp
Modified:
3 years, 9 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, nona+watch_chromium.org, shuchen+watch_chromium.org, James Su, yusukes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make SelectionPopupController.ShowPastePopup only be triggered by Blink (patchset #3 id:40001 of https://codereview.chromium.org/2721813002/ ) Reason for revert: Caused flakiness (crbug.com/697934) Original issue's description: > Make SelectionPopupController.ShowPastePopup only be triggered by Blink > > > This patch is progress towards the goal of having Blink triggering all > of clank's SelectActionMode context menus. In particular this patch > has Blink trigger the menu when an insertion handle is tapped or > dragged. > > BUG=627234 > > Review-Url: https://codereview.chromium.org/2721813002 > Cr-Commit-Position: refs/heads/master@{#454203} > Committed: https://chromium.googlesource.com/chromium/src/+/f88569b6a113509e7e7245ca297221701d07d4a3 TBR=aelias@chromium.org,boliu@chromium.org,jinsukkim@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=627234 Review-Url: https://codereview.chromium.org/2727203003 Cr-Commit-Position: refs/heads/master@{#454355} Committed: https://chromium.googlesource.com/chromium/src/+/7a5687419f74d3767023162b603ac08b2a998dc6

Patch Set 1 #

Messages

Total messages: 13 (6 generated)
amaralp
Created Revert of Make SelectionPopupController.ShowPastePopup only be triggered by Blink
3 years, 9 months ago (2017-03-02 19:50:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727203003/1
3 years, 9 months ago (2017-03-02 19:51:37 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 9 months ago (2017-03-02 19:51:39 UTC) #5
aelias_OOO_until_Jul13
lgtm
3 years, 9 months ago (2017-03-02 19:52:13 UTC) #7
boliu
rs lgtm
3 years, 9 months ago (2017-03-02 19:52:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727203003/1
3 years, 9 months ago (2017-03-02 19:53:02 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 20:02:11 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7a5687419f74d3767023162b603a...

Powered by Google App Engine
This is Rietveld 408576698