content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java - Issue 2727203003: Revert of Make SelectionPopupController.ShowPastePopup only be triggered by Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

Issue 2727203003: Revert of Make SelectionPopupController.ShowPastePopup only be triggered by Blink (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/web_contents/web_contents_android.cc ('k') | content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java b/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

index a7401726903a909bb2a4ec365a7e9ffd6b2f6da8..9b5936055b1ef659241700a224e1e81bd5d7349f 100644

--- a/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

+++ b/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

@@ -798,7 +798,7 @@

case SelectionEventType.INSERTION_HANDLE_MOVED:

mSelectionRect.set(left, top, right, bottom);

if (!isScrollInProgress && isPastePopupShowing()) {

- mWebContents.showContextMenuAtPoint(xAnchor, yAnchor);

+ showPastePopup(xAnchor, yAnchor);

} else {

hidePastePopup();

}

@@ -808,7 +808,7 @@

if (mWasPastePopupShowingOnInsertionDragStart) {

hidePastePopup();

} else {

- mWebContents.showContextMenuAtPoint(xAnchor, yAnchor);

+ showPastePopup(xAnchor, yAnchor);

}

mWasPastePopupShowingOnInsertionDragStart = false;

break;

@@ -826,7 +826,7 @@

case SelectionEventType.INSERTION_HANDLE_DRAG_STOPPED:

if (mWasPastePopupShowingOnInsertionDragStart) {

- mWebContents.showContextMenuAtPoint(xAnchor, yAnchor);

+ showPastePopup(xAnchor, yAnchor);

}

mWasPastePopupShowingOnInsertionDragStart = false;

break;