Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 2726933002: [DevTools] Console should wait for the main target (Closed)
Patch Set: [DevTools] Console should wait for the main target Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
index e435228680f86067dc7938fe70f8fe0855754dd6..084a5c4f2233bcffa620321a92c6c007803b12cb 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
@@ -168,8 +168,6 @@ Console.ConsoleView = class extends UI.VBox {
this._registerWithMessageSink();
SDK.targetManager.observeTargets(this);
- this._initConsoleMessages();
-
UI.context.addFlavorChangeListener(SDK.ExecutionContext, this._executionContextChanged, this);
this._messagesElement.addEventListener('mousedown', this._updateStickToBottomOnMouseDown.bind(this), false);
@@ -210,14 +208,14 @@ Console.ConsoleView = class extends UI.VBox {
this._prompt.setAddCompletionsFromHistory(this._consoleHistoryAutocompleteSetting.get());
}
- _initConsoleMessages() {
- var mainTarget = SDK.targetManager.mainTarget();
- var resourceTreeModel = mainTarget && SDK.ResourceTreeModel.fromTarget(mainTarget);
- var resourcesLoaded = !resourceTreeModel || resourceTreeModel.cachedResourcesLoaded();
- if (!mainTarget || !resourcesLoaded) {
- SDK.targetManager.addModelListener(
- SDK.ResourceTreeModel, SDK.ResourceTreeModel.Events.CachedResourcesLoaded, this._onResourceTreeModelLoaded,
- this);
+ /**
+ * @param {!SDK.Target} target
+ */
+ _initConsoleMessages(target) {
+ var resourceTreeModel = SDK.ResourceTreeModel.fromTarget(target);
+ if (resourceTreeModel && !resourceTreeModel.cachedResourcesLoaded()) {
+ resourceTreeModel.addEventListener(
+ SDK.ResourceTreeModel.Events.CachedResourcesLoaded, this._onResourceTreeModelLoaded, this);
return;
}
this._fetchMultitargetMessages();
@@ -228,11 +226,8 @@ Console.ConsoleView = class extends UI.VBox {
*/
_onResourceTreeModelLoaded(event) {
var resourceTreeModel = /** @type {!SDK.ResourceTreeModel} */ (event.data);
- if (resourceTreeModel.target() !== SDK.targetManager.mainTarget())
- return;
- SDK.targetManager.removeModelListener(
- SDK.ResourceTreeModel, SDK.ResourceTreeModel.Events.CachedResourcesLoaded, this._onResourceTreeModelLoaded,
- this);
+ resourceTreeModel.removeEventListener(
+ SDK.ResourceTreeModel.Events.CachedResourcesLoaded, this._onResourceTreeModelLoaded, this);
this._fetchMultitargetMessages();
}
@@ -287,6 +282,8 @@ Console.ConsoleView = class extends UI.VBox {
* @param {!SDK.Target} target
*/
targetAdded(target) {
+ if (target === SDK.targetManager.mainTarget())
+ this._initConsoleMessages(target);
this._viewport.invalidate();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698