Remove WmLookup.

Remove WmLookup.

Since we no longer need WmLookup, WmLookup.(c|hh) and
WmLookup(Aura|Mus).(c|hh) will be removed.

The calling sites to WmLookup::GetWindowForWidget(widget) can just call 
WmWindow::Get(widget->GetNativeWindow()).

The calling sites to WmLookup::GetRootWindowControllerWithDisplayId(id) 
can just call Shell::GetRootWindowControllerWithDisplayId(id).

Review-Url: https://codereview.chromium.org/2726823003
Cr-Commit-Position: refs/heads/master@{#454615}
Committed: https://chromium.googlesource.com/chromium/src/+/c90f49ca766d5403ccb7d16180f91f5aa32f603e

[thanhph1, 2017-03-01 20:05:59]

Description was changed from

==========
Remove WmLookup.

We no longer need WmLookup. This cl removes WmLookup and all of their
refs.

Remove WmLookup::GetWindowForWidget().

BUG=687658
==========

to

==========
Remove WmLookup.

We no longer need WmLookup. This cl removes WmLookup and all of their
refs.

BUG=687658
==========

[thanhph1, 2017-03-01 20:06:14]

The CQ bit was checked by thanhph@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 20:06:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[thanhph1, 2017-03-01 20:18:29]

Description was changed from

==========
Remove WmLookup.

We no longer need WmLookup. This cl removes WmLookup and all of their
refs.

BUG=687658
==========

to

==========
Remove WmLookup.

Since we no longer need WmLookup, WmLookup.(c|hh) and
WmLookup(Aura|Mus).(c|hh) will be removed.

The calling sites to GetWindowForWidget() can just 
call WmWindow::Get(widget->GetNativeWindow()).

The calling sites to 
GetRootWindowControllerWithDisplayId() can just call  
Shell::GetRootWindowControllerWithDisplayId().


BUG=687658
==========

[thanhph1, 2017-03-01 20:18:41]

Description was changed from

==========
Remove WmLookup.

Since we no longer need WmLookup, WmLookup.(c|hh) and
WmLookup(Aura|Mus).(c|hh) will be removed.

The calling sites to GetWindowForWidget() can just 
call WmWindow::Get(widget->GetNativeWindow()).

The calling sites to 
GetRootWindowControllerWithDisplayId() can just call  
Shell::GetRootWindowControllerWithDisplayId().


BUG=687658
==========

to

==========
Remove WmLookup.

Since we no longer need WmLookup, WmLookup.(c|hh) and
WmLookup(Aura|Mus).(c|hh) will be removed.

The calling sites to GetWindowForWidget() can just 
call WmWindow::Get(widget->GetNativeWindow()).

The calling sites to 
GetRootWindowControllerWithDisplayId() can just call  
Shell::GetRootWindowControllerWithDisplayId().

BUG=687658
==========

[commit-bot: I haz the power, 2017-03-01 20:40:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 20:40:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[thanhph1, 2017-03-01 22:27:14]

Patchset #2 (id:20001) has been deleted

[thanhph1, 2017-03-01 23:12:48]

The CQ bit was checked by thanhph@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 23:13:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[thanhph1, 2017-03-01 23:16:13]

Description was changed from

==========
Remove WmLookup.

Since we no longer need WmLookup, WmLookup.(c|hh) and
WmLookup(Aura|Mus).(c|hh) will be removed.

The calling sites to GetWindowForWidget() can just 
call WmWindow::Get(widget->GetNativeWindow()).

The calling sites to 
GetRootWindowControllerWithDisplayId() can just call  
Shell::GetRootWindowControllerWithDisplayId().

BUG=687658
==========

to

==========
Remove WmLookup.

Since we no longer need WmLookup, WmLookup.(c|hh) and
WmLookup(Aura|Mus).(c|hh) will be removed.

The calling sites to GetWindowForWidget() can just call 
WmWindow::Get(widget->GetNativeWindow()).

The calling sites to GetRootWindowControllerWithDisplayId() can just
call Shell::GetRootWindowControllerWithDisplayId()
==========

[thanhph1, 2017-03-01 23:17:13]

Description was changed from

==========
Remove WmLookup.

Since we no longer need WmLookup, WmLookup.(c|hh) and
WmLookup(Aura|Mus).(c|hh) will be removed.

The calling sites to GetWindowForWidget() can just call 
WmWindow::Get(widget->GetNativeWindow()).

The calling sites to GetRootWindowControllerWithDisplayId() can just
call Shell::GetRootWindowControllerWithDisplayId()
==========

to

==========
Remove WmLookup.

Since we no longer need WmLookup, WmLookup.(c|hh) and
WmLookup(Aura|Mus).(c|hh) will be removed.

The calling sites to WmLookup::GetWindowForWidget() can just call 
WmWindow::Get(widget->GetNativeWindow()).

The calling sites to WmLookup::GetRootWindowControllerWithDisplayId() 
can just call Shell::GetRootWindowControllerWithDisplayId()
==========

[thanhph1, 2017-03-01 23:17:57]

Description was changed from

==========
Remove WmLookup.

Since we no longer need WmLookup, WmLookup.(c|hh) and
WmLookup(Aura|Mus).(c|hh) will be removed.

The calling sites to WmLookup::GetWindowForWidget() can just call 
WmWindow::Get(widget->GetNativeWindow()).

The calling sites to WmLookup::GetRootWindowControllerWithDisplayId() 
can just call Shell::GetRootWindowControllerWithDisplayId()
==========

to

==========
Remove WmLookup.

Since we no longer need WmLookup, WmLookup.(c|hh) and
WmLookup(Aura|Mus).(c|hh) will be removed.

The calling sites to WmLookup::GetWindowForWidget(widget) can just call 
WmWindow::Get(widget->GetNativeWindow()).

The calling sites to WmLookup::GetRootWindowControllerWithDisplayId(id) 
can just call Shell::GetRootWindowControllerWithDisplayId(id)
==========

[commit-bot: I haz the power, 2017-03-02 00:44:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 00:44:09]

Dry run: This issue passed the CQ dry run.

[thanhph1, 2017-03-02 00:48:37]

Patchset #2 (id:40001) has been deleted

[thanhph1, 2017-03-02 00:48:50]

The CQ bit was checked by thanhph@google.com to run a CQ dry run

[thanhph1, 2017-03-02 00:48:59]

Patchset #2 (id:60001) has been deleted

[commit-bot: I haz the power, 2017-03-02 00:49:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 02:34:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 02:34:26]

Dry run: This issue passed the CQ dry run.

[thanhph1, 2017-03-02 15:16:33]

thanhph@google.com changed reviewers:
+ sky@chromium.org

[thanhph1, 2017-03-02 15:16:34]

Hi Scott, 

Please review my cl.

Thanks,
Thanh.

[thanhph1, 2017-03-02 15:16:55]

Description was changed from

==========
Remove WmLookup.

Since we no longer need WmLookup, WmLookup.(c|hh) and
WmLookup(Aura|Mus).(c|hh) will be removed.

The calling sites to WmLookup::GetWindowForWidget(widget) can just call 
WmWindow::Get(widget->GetNativeWindow()).

The calling sites to WmLookup::GetRootWindowControllerWithDisplayId(id) 
can just call Shell::GetRootWindowControllerWithDisplayId(id)
==========

to

==========
Remove WmLookup.

Since we no longer need WmLookup, WmLookup.(c|hh) and
WmLookup(Aura|Mus).(c|hh) will be removed.

The calling sites to WmLookup::GetWindowForWidget(widget) can just call 
WmWindow::Get(widget->GetNativeWindow()).

The calling sites to WmLookup::GetRootWindowControllerWithDisplayId(id) 
can just call Shell::GetRootWindowControllerWithDisplayId(id).
==========

[sky, 2017-03-02 19:04:52]

I got part way through this and realized you have a bunch of unnecessary
.get()'s. Please take another pass over this and clean those up.

Also, next time around I recommend splitting this into two patches. One that
removes GetWindowForWidget and another for the display. But, since you combined
them here we'll go with this.

https://codereview.chromium.org/2726823003/diff/80001/ash/common/devtools/ash...
File ash/common/devtools/ash_devtools_unittest.cc (right):

https://codereview.chromium.org/2726823003/diff/80001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_unittest.cc:301: WmWindow* parent_window =
WmWindow::Get(widget.get()->GetNativeWindow());
Remove the .get() in all these, e.g. widget->GetNativeWindow().

https://codereview.chromium.org/2726823003/diff/80001/ash/common/drag_drop/dr...
File ash/common/drag_drop/drag_image_view.cc (right):

https://codereview.chromium.org/2726823003/diff/80001/ash/common/drag_drop/dr...
ash/common/drag_drop/drag_image_view.cc:124: WmWindow* window =
WmWindow::Get(widget_.get()->GetNativeWindow());
no .get()

[thanhph1, 2017-03-02 20:08:19]

The CQ bit was checked by thanhph@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 20:08:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 20:12:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 20:12:37]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[thanhph1, 2017-03-02 20:25:21]

Patchset #3 (id:100001) has been deleted

[thanhph1, 2017-03-02 21:04:37]

The CQ bit was checked by thanhph@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 21:05:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 21:09:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 21:09:54]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[thanhph1, 2017-03-02 21:20:07]

The CQ bit was checked by thanhph@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 21:20:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 22:15:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 22:15:41]

Dry run: This issue passed the CQ dry run.

[thanhph1, 2017-03-02 22:24:17]

https://codereview.chromium.org/2726823003/diff/80001/ash/common/devtools/ash...
File ash/common/devtools/ash_devtools_unittest.cc (right):

https://codereview.chromium.org/2726823003/diff/80001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_unittest.cc:301: WmWindow* parent_window =
WmWindow::Get(widget.get()->GetNativeWindow());
On 2017/03/02 19:04:52, sky wrote:
> Remove the .get() in all these, e.g. widget->GetNativeWindow().

Thanks Scott, I double-checked and removed all of .get(). I can split this code
into 2 patches if you find it easier to review.

Thanks,
Thanh.

https://codereview.chromium.org/2726823003/diff/80001/ash/common/drag_drop/dr...
File ash/common/drag_drop/drag_image_view.cc (right):

https://codereview.chromium.org/2726823003/diff/80001/ash/common/drag_drop/dr...
ash/common/drag_drop/drag_image_view.cc:124: WmWindow* window =
WmWindow::Get(widget_.get()->GetNativeWindow());
On 2017/03/02 19:04:52, sky wrote:
> no .get()

Done.

[sky, 2017-03-02 23:49:57]

https://codereview.chromium.org/2726823003/diff/140001/ash/common/system/toas...
File ash/common/system/toast/toast_overlay.cc (right):

https://codereview.chromium.org/2726823003/diff/140001/ash/common/system/toas...
ash/common/system/toast/toast_overlay.cc:8: #include
"ash/common/strings/grit/ash_strings.h"
Did you mean to add this include?

https://codereview.chromium.org/2726823003/diff/140001/ash/shell.h
File ash/shell.h (right):

https://codereview.chromium.org/2726823003/diff/140001/ash/shell.h#newcode165
ash/shell.h:165: // Return RootWindowController* if RootWindowController with
specified
How about: Returns the RootWindowController for the given display id. If there
is no display for |display_id|, null is returned.

[thanhph1, 2017-03-03 15:36:32]

The CQ bit was checked by thanhph@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 15:36:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 16:25:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 16:25:19]

Dry run: This issue passed the CQ dry run.

[thanhph1, 2017-03-03 16:29:54]

Thanks Scott. I rebased again this morning. Please review my new patch!

Thanks,
Thanh.

https://codereview.chromium.org/2726823003/diff/140001/ash/common/system/toas...
File ash/common/system/toast/toast_overlay.cc (right):

https://codereview.chromium.org/2726823003/diff/140001/ash/common/system/toas...
ash/common/system/toast/toast_overlay.cc:8: #include
"ash/common/strings/grit/ash_strings.h"
On 2017/03/02 23:49:57, sky wrote:
> Did you mean to add this include?

I thought this was the result of the merge. I removed this include, thanks!

https://codereview.chromium.org/2726823003/diff/140001/ash/shell.h
File ash/shell.h (right):

https://codereview.chromium.org/2726823003/diff/140001/ash/shell.h#newcode165
ash/shell.h:165: // Return RootWindowController* if RootWindowController with
specified
On 2017/03/02 23:49:57, sky wrote:
> How about: Returns the RootWindowController for the given display id. If there
> is no display for |display_id|, null is returned.

Done, sounds good!

[sky, 2017-03-03 17:08:25]

LGTM

[thanhph1, 2017-03-03 17:38:38]

The CQ bit was checked by thanhph@google.com

[commit-bot: I haz the power, 2017-03-03 17:39:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[thanhph1, 2017-03-03 17:39:10]

On 2017/03/03 17:08:25, sky wrote:
> LGTM

Great, thanks Scott!

Thanh.

[commit-bot: I haz the power, 2017-03-03 17:48:59]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1488562718311620,
"parent_rev": "b05824d69f2a8403552ef9e29bebdece24005400", "commit_rev":
"c90f49ca766d5403ccb7d16180f91f5aa32f603e"}

[commit-bot: I haz the power, 2017-03-03 17:49:39]

Description was changed from

==========
Remove WmLookup.

Since we no longer need WmLookup, WmLookup.(c|hh) and
WmLookup(Aura|Mus).(c|hh) will be removed.

The calling sites to WmLookup::GetWindowForWidget(widget) can just call 
WmWindow::Get(widget->GetNativeWindow()).

The calling sites to WmLookup::GetRootWindowControllerWithDisplayId(id) 
can just call Shell::GetRootWindowControllerWithDisplayId(id).
==========

to

==========
Remove WmLookup.

Since we no longer need WmLookup, WmLookup.(c|hh) and
WmLookup(Aura|Mus).(c|hh) will be removed.

The calling sites to WmLookup::GetWindowForWidget(widget) can just call 
WmWindow::Get(widget->GetNativeWindow()).

The calling sites to WmLookup::GetRootWindowControllerWithDisplayId(id) 
can just call Shell::GetRootWindowControllerWithDisplayId(id).

Review-Url: https://codereview.chromium.org/2726823003
Cr-Commit-Position: refs/heads/master@{#454615}
Committed:
https://chromium.googlesource.com/chromium/src/+/c90f49ca766d5403ccb7d16180f9...
==========

[commit-bot: I haz the power, 2017-03-03 17:49:40]

Committed patchset #5 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/c90f49ca766d5403ccb7d16180f9...