Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2726763002: [Devtools] Fixed flicker in network for large stream of requests (Closed)

Created:
3 years, 9 months ago by allada
Modified:
3 years, 9 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fixed flicker in network for large stream of requests This patch updates network to update the ViewportDataGrid instantly which fixes the flicker. Reason this occurs is because network gets an update to a request which schedules an update. It finds a new node now needs to be added so it sends it to datagrid and waterfall to be added which Waterfall processes immidatly, but ViewportDataGrid schedules the next frame to insert the new nodes. The scroller then gets synced and stick to bottom kicks in which causes the scroller to scroll down which reveals blank area in the ViewportDataGrid. R=pfeldman BUG=697273 Review-Url: https://codereview.chromium.org/2726763002 Cr-Commit-Position: refs/heads/master@{#454319} Committed: https://chromium.googlesource.com/chromium/src/+/c2be7423611e6bfdb7400e46c6d265f53c3888a3

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M third_party/WebKit/LayoutTests/inspector/components/viewport-datagrid.html View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 11 (7 generated)
allada
PTL
3 years, 9 months ago (2017-03-01 01:19:37 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/2726763002/diff/1/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js (right): https://codereview.chromium.org/2726763002/diff/1/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js#newcode857 third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:857: this._dataGrid.updateInstantly(); rename it to forceUpdate.
3 years, 9 months ago (2017-03-02 00:11:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2726763002/1
3 years, 9 months ago (2017-03-02 17:21:34 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 18:49:06 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c2be7423611e6bfdb7400e46c6d2...

Powered by Google App Engine
This is Rietveld 408576698