Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Unified Diff: third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js

Issue 2726763002: [Devtools] Fixed flicker in network for large stream of requests (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js
diff --git a/third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js b/third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js
index 5b75ec34be5fa33e591947df1fd733d64566d5fe..94904508a88b9182086651f4a436c90e0fa83637 100644
--- a/third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js
+++ b/third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js
@@ -101,10 +101,10 @@ DataGrid.ViewportDataGrid = class extends DataGrid.DataGrid {
this._updateAnimationFrameId = this.element.window().requestAnimationFrame(this._update.bind(this));
}
- updateInstantlyForTests() {
- if (!this._updateAnimationFrameId)
- return;
- this.element.window().cancelAnimationFrame(this._updateAnimationFrameId);
+ // TODO(allada) This should be fixed to never be needed. It is needed right now for network because removing
+ // elements happens followed by a scheduleRefresh() which causes white space to be visible, but the waterfall
+ // updates instantly.
+ updateInstantly() {
this._update();
}

Powered by Google App Engine
This is Rietveld 408576698