Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2726293002: Revert of TestCompositorFrameSink should use CompositorFrameSinkSupport (Closed)

Created:
3 years, 9 months ago by danakj
Modified:
3 years, 9 months ago
Reviewers:
Fady Samuel, Saman Sami
CC:
chromium-reviews, cc-bugs_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of TestCompositorFrameSink should use CompositorFrameSinkSupport (patchset #5 id:80001 of https://codereview.chromium.org/2724383002/ ) Reason for revert: TextureLayerMailboxIsActivatedDuringCommit.RunMultiThread_DelegatingRenderer failing (I think flakily) Original issue's description: > TestCompositorFrameSink should use CompositorFrameSinkSupport > > Test should help us expand the test coverage of CompositorFrameSinkSupport. > > TextureLayerChangeInvisibleMailboxTest needed to be changed because > after switching to CompositorFrameSinkSupport returning resources > is delayed until an ack is received unlike SurfaceFactory > which returns the resources immediately, so mailboxes can potentially > be released later than before and this messes with the checks. > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2724383002 > Cr-Commit-Position: refs/heads/master@{#454403} > Committed: https://chromium.googlesource.com/chromium/src/+/146d1bb3fa62905c98950fbe510f7520935cc07b TBR=fsamuel@chromium.org,samans@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2726293002 Cr-Commit-Position: refs/heads/master@{#454431} Committed: https://chromium.googlesource.com/chromium/src/+/5e6a1567a4353cd1b32ed70e7fe887450bacc2d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -78 lines) Patch
M cc/layers/texture_layer_unittest.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M cc/test/test_compositor_frame_sink.h View 6 chunks +10 lines, -18 lines 0 comments Download
M cc/test/test_compositor_frame_sink.cc View 5 chunks +49 lines, -50 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
danakj
Created Revert of TestCompositorFrameSink should use CompositorFrameSinkSupport
3 years, 9 months ago (2017-03-02 23:28:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2726293002/1
3 years, 9 months ago (2017-03-02 23:29:14 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 23:30:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5e6a1567a4353cd1b32ed70e7fe8...

Powered by Google App Engine
This is Rietveld 408576698