Chromium Code Reviews
DescriptionRevert of TestCompositorFrameSink should use CompositorFrameSinkSupport (patchset #5 id:80001 of https://codereview.chromium.org/2724383002/ )
Reason for revert:
TextureLayerMailboxIsActivatedDuringCommit.RunMultiThread_DelegatingRenderer failing (I think flakily)
Original issue's description:
> TestCompositorFrameSink should use CompositorFrameSinkSupport
>
> Test should help us expand the test coverage of CompositorFrameSinkSupport.
>
> TextureLayerChangeInvisibleMailboxTest needed to be changed because
> after switching to CompositorFrameSinkSupport returning resources
> is delayed until an ack is received unlike SurfaceFactory
> which returns the resources immediately, so mailboxes can potentially
> be released later than before and this messes with the checks.
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Review-Url: https://codereview.chromium.org/2724383002
> Cr-Commit-Position: refs/heads/master@{#454403}
> Committed: https://chromium.googlesource.com/chromium/src/+/146d1bb3fa62905c98950fbe510f7520935cc07b
TBR=fsamuel@chromium.org,samans@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2726293002
Cr-Commit-Position: refs/heads/master@{#454431}
Committed: https://chromium.googlesource.com/chromium/src/+/5e6a1567a4353cd1b32ed70e7fe887450bacc2d3
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
|||||||||||||||||||||||||||||||||||||