Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Unified Diff: cc/test/test_compositor_frame_sink.h

Issue 2726293002: Revert of TestCompositorFrameSink should use CompositorFrameSinkSupport (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/texture_layer_unittest.cc ('k') | cc/test/test_compositor_frame_sink.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/test/test_compositor_frame_sink.h
diff --git a/cc/test/test_compositor_frame_sink.h b/cc/test/test_compositor_frame_sink.h
index 32843804c1d944294615831ed3737ce0c428278b..34d8920f88222cf289016d1fe9905a480d42d190 100644
--- a/cc/test/test_compositor_frame_sink.h
+++ b/cc/test/test_compositor_frame_sink.h
@@ -10,10 +10,11 @@
#include "cc/output/compositor_frame_sink.h"
#include "cc/output/renderer_settings.h"
#include "cc/scheduler/begin_frame_source.h"
-#include "cc/surfaces/compositor_frame_sink_support_client.h"
#include "cc/surfaces/display.h"
#include "cc/surfaces/display_client.h"
#include "cc/surfaces/local_surface_id_allocator.h"
+#include "cc/surfaces/surface_factory.h"
+#include "cc/surfaces/surface_factory_client.h"
#include "cc/surfaces/surface_manager.h"
namespace base {
@@ -21,7 +22,6 @@
}
namespace cc {
-class CompositorFrameSinkSupport;
class CopyOutputRequest;
class OutputSurface;
@@ -42,9 +42,8 @@
// CompositorFrameSink that owns and forwards frames to a Display.
class TestCompositorFrameSink : public CompositorFrameSink,
- public CompositorFrameSinkSupportClient,
- public DisplayClient,
- public ExternalBeginFrameSourceClient {
+ public SurfaceFactoryClient,
+ public DisplayClient {
public:
// Pass true for |force_disable_reclaim_resources| to act like the Display
// is out-of-process and can't return resources synchronously.
@@ -78,12 +77,9 @@
void SubmitCompositorFrame(CompositorFrame frame) override;
void ForceReclaimResources() override;
- // CompositorFrameSinkSupportClient implementation.
- void DidReceiveCompositorFrameAck() override;
- void OnBeginFrame(const BeginFrameArgs& args) override;
- void ReclaimResources(const ReturnedResourceArray& resources) override;
- void WillDrawSurface(const LocalSurfaceId& local_surface_id,
- const gfx::Rect& damage_rect) override;
+ // SurfaceFactoryClient implementation.
+ void ReturnResources(const ReturnedResourceArray& resources) override;
+ void SetBeginFrameSource(BeginFrameSource* begin_frame_source) override;
// DisplayClient implementation.
void DisplayOutputSurfaceLost() override;
@@ -92,11 +88,7 @@
void DisplayDidDrawAndSwap() override;
private:
- // ExternalBeginFrameSource implementation.
- void OnNeedsBeginFrames(bool needs_begin_frames) override;
- void OnDidFinishFrame(const BeginFrameAck& ack) override;
-
- void SendCompositorFrameAckToClient();
+ void DidDrawCallback();
const bool synchronous_composite_;
const RendererSettings renderer_settings_;
@@ -111,14 +103,14 @@
LocalSurfaceId delegated_local_surface_id_;
// Uses surface_manager_.
- std::unique_ptr<CompositorFrameSinkSupport> support_;
+ std::unique_ptr<SurfaceFactory> surface_factory_;
std::unique_ptr<SyntheticBeginFrameSource> begin_frame_source_;
- ExternalBeginFrameSource external_begin_frame_source_;
// Uses surface_manager_ and begin_frame_source_.
std::unique_ptr<Display> display_;
+ bool bound_ = false;
TestCompositorFrameSinkClient* test_client_ = nullptr;
gfx::Size enlarge_pass_texture_amount_;
« no previous file with comments | « cc/layers/texture_layer_unittest.cc ('k') | cc/test/test_compositor_frame_sink.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698