Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2726243002: Move VR test APK downloading behind an env var (Closed)

Created:
3 years, 9 months ago by bsheedy
Modified:
3 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move VR test APK downloading behind an env var BUG=697469 Review-Url: https://codereview.chromium.org/2726243002 Cr-Commit-Position: refs/heads/master@{#454628} Committed: https://chromium.googlesource.com/chromium/src/+/516f85ba30f7359e8a63eadc0287429f40d877be

Patch Set 1 #

Total comments: 1

Patch Set 2 : print check_output > check_call #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -22 lines) Patch
M DEPS View 2 chunks +8 lines, -22 lines 0 comments Download
A third_party/gvr-android-sdk/test-apks/update.py View 1 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
bsheedy
PTAL
3 years, 9 months ago (2017-03-02 19:37:20 UTC) #2
Nico
lgtm, thanks https://codereview.chromium.org/2726243002/diff/1/third_party/gvr-android-sdk/test-apks/update.py File third_party/gvr-android-sdk/test-apks/update.py (right): https://codereview.chromium.org/2726243002/diff/1/third_party/gvr-android-sdk/test-apks/update.py#newcode12 third_party/gvr-android-sdk/test-apks/update.py:12: print subprocess.check_output(['download_from_google_storage', Use check_call instead of print ...
3 years, 9 months ago (2017-03-03 15:51:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2726243002/20001
3 years, 9 months ago (2017-03-03 17:26:32 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 18:27:10 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/516f85ba30f7359e8a63eadc0287...

Powered by Google App Engine
This is Rietveld 408576698