third_party/gvr-android-sdk/test-apks/update.py - Issue 2726243002: Move VR test APK downloading behind an env var

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/gvr-android-sdk/test-apks/update.py

Issue 2726243002: Move VR test APK downloading behind an env var (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 import os

	2 import subprocess

	3 import sys

	4

	5 THIS_DIR = os.path.abspath(os.path.dirname(__file__))

	6 DAYDREAM_DIR = os.path.abspath(os.path.join(THIS_DIR, 'daydream_home'))

	7 VR_SERVICES_DIR = os.path.abspath(os.path.join(THIS_DIR, 'vr_services'))

	8

	9 def main():

	10 if 'DOWNLOAD_VR_TEST_APKS' not in os.environ:

	11 return 0

	12 print subprocess.check_output(['download_from_google_storage',
	Nico 2017/03/03 15:51:59 Use check_call instead of print check_output. che Use check_call instead of print check_output. check_output redirects the default stdout to a pipe and reads from that to give you the output as a string, which you then send to standard output. check_call doesn't redirect standard output in the first place.
	13 '--bucket', 'chrome-vr-test-apks/daydream_home',

	14 '-d', DAYDREAM_DIR])

	15 print subprocess.check_output(['download_from_google_storage',

	16 '--bucket', 'chrome-vr-test-apks/vr_services',

	17 '-d', VR_SERVICES_DIR])

	18 return 0

	19

	20 if __name__ == '__main__':

	21 sys.exit(main())

OLD	NEW

« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »