Stop using SVGElementInstance in SVGElement

Stop using SVGElementInstance in SVGElement

Stop using SVGElementInstance in SVGElement since we want to remove it.

BUG=313438
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173637

[rwlbuis, 2014-05-07 22:19:52]

PTAL, one more small refactor along the way :)

[pdr., 2014-05-07 22:27:22]

LGTM with a nit.

https://codereview.chromium.org/272623003/diff/1/Source/core/svg/SVGElement.cpp
File Source/core/svg/SVGElement.cpp (right):

https://codereview.chromium.org/272623003/diff/1/Source/core/svg/SVGElement.c...
Source/core/svg/SVGElement.cpp:536: 
I think the assertion here was useful (similarly in removeInstanceMapping).
Could we add it back?

Something like:
ASSERT(instance->inUseShadowTree());

[rwlbuis, 2014-05-07 22:43:06]

On 2014/05/07 22:27:22, pdr wrote:
> LGTM with a nit.
> 
>
https://codereview.chromium.org/272623003/diff/1/Source/core/svg/SVGElement.cpp
> File Source/core/svg/SVGElement.cpp (right):
> 
>
https://codereview.chromium.org/272623003/diff/1/Source/core/svg/SVGElement.c...
> Source/core/svg/SVGElement.cpp:536: 
> I think the assertion here was useful (similarly in removeInstanceMapping).
> Could we add it back?
> 
> Something like:
> ASSERT(instance->inUseShadowTree());

Well the old assertion was slightly different, at least the above assert was
only implied by shadowTreeElement() existing. But I agree it is a good check,
will add.

[rwlbuis, 2014-05-08 10:34:40]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-05-08 10:35:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rob.buis@samsung.com/272623003/40001

[commit-bot: I haz the power, 2014-05-08 11:13:39]

Change committed as 173637