Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 272623003: Stop using SVGElementInstance in SVGElement (Closed)

Created:
6 years, 7 months ago by rwlbuis
Modified:
6 years, 7 months ago
Reviewers:
pdr.
CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr.
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Stop using SVGElementInstance in SVGElement Stop using SVGElementInstance in SVGElement since we want to remove it. BUG=313438 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173637

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add assertion #

Patch Set 3 : Do shadow dom deletion later #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -22 lines) Patch
M Source/core/svg/SVGElement.h View 1 2 4 chunks +2 lines, -6 lines 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 2 2 chunks +8 lines, -10 lines 0 comments Download
M Source/core/svg/SVGElementInstance.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 1 2 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rwlbuis
PTAL, one more small refactor along the way :)
6 years, 7 months ago (2014-05-07 22:19:52 UTC) #1
pdr.
LGTM with a nit. https://codereview.chromium.org/272623003/diff/1/Source/core/svg/SVGElement.cpp File Source/core/svg/SVGElement.cpp (right): https://codereview.chromium.org/272623003/diff/1/Source/core/svg/SVGElement.cpp#newcode536 Source/core/svg/SVGElement.cpp:536: I think the assertion here ...
6 years, 7 months ago (2014-05-07 22:27:22 UTC) #2
rwlbuis
On 2014/05/07 22:27:22, pdr wrote: > LGTM with a nit. > > https://codereview.chromium.org/272623003/diff/1/Source/core/svg/SVGElement.cpp > File ...
6 years, 7 months ago (2014-05-07 22:43:06 UTC) #3
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 7 months ago (2014-05-08 10:34:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/272623003/40001
6 years, 7 months ago (2014-05-08 10:35:15 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-08 11:13:39 UTC) #6
Message was sent while issue was closed.
Change committed as 173637

Powered by Google App Engine
This is Rietveld 408576698