Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: Source/core/svg/SVGUseElement.cpp

Issue 272623003: Stop using SVGElementInstance in SVGElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Do shadow dom deletion later Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGElementInstance.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGUseElement.cpp
diff --git a/Source/core/svg/SVGUseElement.cpp b/Source/core/svg/SVGUseElement.cpp
index cdb277c033d1fc467a8d29f2b34f37f3188f3baa..6f1810fc5577b20348396ba8b71d26a62a1ec722 100644
--- a/Source/core/svg/SVGUseElement.cpp
+++ b/Source/core/svg/SVGUseElement.cpp
@@ -324,15 +324,15 @@ void SVGUseElement::scheduleShadowTreeRecreation()
void SVGUseElement::clearResourceReferences()
{
- // FIXME: We should try to optimize this, to at least allow partial reclones.
- if (ShadowRoot* shadowTreeRootElement = userAgentShadowRoot())
- shadowTreeRootElement->removeChildren();
-
if (m_targetElementInstance) {
m_targetElementInstance->detach();
m_targetElementInstance = nullptr;
}
+ // FIXME: We should try to optimize this, to at least allow partial reclones.
+ if (ShadowRoot* shadowTreeRootElement = userAgentShadowRoot())
+ shadowTreeRootElement->removeChildren();
+
m_needsShadowTreeRecreation = false;
document().unscheduleUseShadowTreeUpdate(*this);
« no previous file with comments | « Source/core/svg/SVGElementInstance.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698