Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1640)

Unified Diff: Source/core/svg/SVGElementInstance.cpp

Issue 272623003: Stop using SVGElementInstance in SVGElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Do shadow dom deletion later Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGElement.cpp ('k') | Source/core/svg/SVGUseElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGElementInstance.cpp
diff --git a/Source/core/svg/SVGElementInstance.cpp b/Source/core/svg/SVGElementInstance.cpp
index 75974cd4446e49289f11a3adb739b2fcbb93606e..b4c08892a3cf68bcc6412a077ec264f89fb8f438 100644
--- a/Source/core/svg/SVGElementInstance.cpp
+++ b/Source/core/svg/SVGElementInstance.cpp
@@ -139,7 +139,7 @@ void SVGElementInstance::detach()
// Deregister as instance for passed element, if we haven't already.
if (shadowTreeElement() && m_element->instancesForElement().contains(shadowTreeElement()))
- m_element->removeInstanceMapping(this);
+ m_element->removeInstanceMapping(shadowTreeElement());
// DO NOT clear ref to m_element because JavaScriptCore uses it for garbage collection
m_shadowTreeElement = nullptr;
@@ -157,7 +157,7 @@ void SVGElementInstance::setShadowTreeElement(SVGElement* element)
ASSERT(element);
m_shadowTreeElement = element;
// Register as instance for passed element.
- m_element->mapInstanceToElement(this);
+ m_element->mapInstanceToElement(shadowTreeElement());
}
« no previous file with comments | « Source/core/svg/SVGElement.cpp ('k') | Source/core/svg/SVGUseElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698