[Translate] Add translate ranker model loader (take 2).

[Translate] Add translate ranker model loader.

This is a revert of a revert. It was originally https://codereview.chromium.org/2565873002 which was reverted in https://codereview.chromium.org/2726043003.

Load the TranslateRanker model only if Query is enabled.

This should fix the negative speed regression when Query is not enabled. This condition is controlled through Finch, and is currently only enabled in Canary and Dev. This will allow us to better investigate the speed regression using experimental/control groups.

Also fix the Query/Enforcement logic so that enabling Enforcement automatically enforce Query.

Revert "Revert "[translate] Add translate ranker model loader.""

This reverts commit 9ea997e1d7bbd4350d8793e1629f33c98d00ce2b.

BUG=697665, 646711, 698057
Review-Url: https://codereview.chromium.org/2726203002
Cr-Commit-Position: refs/heads/master@{#454433}
Committed: https://chromium.googlesource.com/chromium/src/+/d005809c83c0ad0b9cbbda6b10b7ed2c3dcd5120

[hamelphi, 2017-03-02 17:04:15]

Description was changed from

==========
Load the Translateranker model only if Query is enabled.

This should fix the negative speed regression when Query is not enabled. This
condition is controlled through Finch, and is currently only enabled in Canary
and Dev. This will allow us to better investigate the speed regression using
experimental/control groups.

Also fix the Query/Enforcement logic so that enabling Enforcement automatically
enforce Query.

Revert "Revert "[translate] Add translate ranker model loader.""

This reverts commit 9ea997e1d7bbd4350d8793e1629f33c98d00ce2b.

BUG=697665, 646711
==========

to

==========
[Translate] Add translate ranker model loader.

This is a revert of a revert. It was originally
https://codereview.chromium.org/2565873002 which was reverted in
https://codereview.chromium.org/2726043003.

Load the TranslateRanker model only if Query is enabled.

This should fix the negative speed regression when Query is not enabled. This
condition is controlled through Finch, and is currently only enabled in Canary
and Dev. This will allow us to better investigate the speed regression using
experimental/control groups.

Also fix the Query/Enforcement logic so that enabling Enforcement automatically
enforce Query.

Revert "Revert "[translate] Add translate ranker model loader.""

This reverts commit 9ea997e1d7bbd4350d8793e1629f33c98d00ce2b.

BUG=697665, 646711
==========

[hamelphi, 2017-03-02 17:04:15]

hamelphi@chromium.org changed reviewers:
+ asanka@chromium.org, fdoray@chromium.org, groby@chromium.org,
rkaplow@chromium.org, sdefresne@chromium.org

[hamelphi, 2017-03-02 17:07:06]

The CQ bit was checked by hamelphi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 17:07:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 17:43:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 17:43:22]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hamelphi, 2017-03-02 18:40:06]

The CQ bit was checked by hamelphi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 18:40:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 20:24:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 20:24:41]

Dry run: This issue passed the CQ dry run.

[asanka, 2017-03-02 20:53:36]

/net/ lgtm

[rkaplow, 2017-03-02 20:54:52]

lgtm

[sdefresne, 2017-03-02 21:54:10]

lgtm (with comments)

https://codereview.chromium.org/2726203002/diff/40001/ios/chrome/browser/tran...
File ios/chrome/browser/translate/translate_ranker_factory.cc (right):

https://codereview.chromium.org/2726203002/diff/40001/ios/chrome/browser/tran...
ios/chrome/browser/translate/translate_ranker_factory.cc:1: // Copyright 2014
The Chromium Authors. All rights reserved.
2014 -> 2017

https://codereview.chromium.org/2726203002/diff/40001/ios/chrome/browser/tran...
File ios/chrome/browser/translate/translate_ranker_factory.h (right):

https://codereview.chromium.org/2726203002/diff/40001/ios/chrome/browser/tran...
ios/chrome/browser/translate/translate_ranker_factory.h:1: // Copyright 2014 The
Chromium Authors. All rights reserved.
2014 -> 2017

https://codereview.chromium.org/2726203002/diff/40001/ios/chrome/browser/tran...
File ios/chrome/browser/translate/translate_ranker_metrics_provider.cc (right):

https://codereview.chromium.org/2726203002/diff/40001/ios/chrome/browser/tran...
ios/chrome/browser/translate/translate_ranker_metrics_provider.cc:1: //
Copyright 2016 The Chromium Authors. All rights reserved.
2016 -> 2017

https://codereview.chromium.org/2726203002/diff/40001/ios/web_view/internal/t...
File ios/web_view/internal/translate/web_view_translate_ranker_factory.cc
(right):

https://codereview.chromium.org/2726203002/diff/40001/ios/web_view/internal/t...
ios/web_view/internal/translate/web_view_translate_ranker_factory.cc:1: //
Copyright 2016 The Chromium Authors. All rights reserved.
2016 -> 2017

https://codereview.chromium.org/2726203002/diff/40001/ios/web_view/internal/t...
File ios/web_view/internal/translate/web_view_translate_ranker_factory.h
(right):

https://codereview.chromium.org/2726203002/diff/40001/ios/web_view/internal/t...
ios/web_view/internal/translate/web_view_translate_ranker_factory.h:1: //
Copyright 2016 The Chromium Authors. All rights reserved.
2016 -> 2017

[hamelphi, 2017-03-02 22:01:00]

https://codereview.chromium.org/2726203002/diff/40001/ios/chrome/browser/tran...
File ios/chrome/browser/translate/translate_ranker_factory.cc (right):

https://codereview.chromium.org/2726203002/diff/40001/ios/chrome/browser/tran...
ios/chrome/browser/translate/translate_ranker_factory.cc:1: // Copyright 2014
The Chromium Authors. All rights reserved.
On 2017/03/02 21:54:10, sdefresne wrote:
> 2014 -> 2017

Done.

https://codereview.chromium.org/2726203002/diff/40001/ios/chrome/browser/tran...
File ios/chrome/browser/translate/translate_ranker_factory.h (right):

https://codereview.chromium.org/2726203002/diff/40001/ios/chrome/browser/tran...
ios/chrome/browser/translate/translate_ranker_factory.h:1: // Copyright 2014 The
Chromium Authors. All rights reserved.
On 2017/03/02 21:54:10, sdefresne wrote:
> 2014 -> 2017

Done.

https://codereview.chromium.org/2726203002/diff/40001/ios/chrome/browser/tran...
File ios/chrome/browser/translate/translate_ranker_metrics_provider.cc (right):

https://codereview.chromium.org/2726203002/diff/40001/ios/chrome/browser/tran...
ios/chrome/browser/translate/translate_ranker_metrics_provider.cc:1: //
Copyright 2016 The Chromium Authors. All rights reserved.
On 2017/03/02 21:54:10, sdefresne wrote:
> 2016 -> 2017

Done.

https://codereview.chromium.org/2726203002/diff/40001/ios/web_view/internal/t...
File ios/web_view/internal/translate/web_view_translate_ranker_factory.cc
(right):

https://codereview.chromium.org/2726203002/diff/40001/ios/web_view/internal/t...
ios/web_view/internal/translate/web_view_translate_ranker_factory.cc:1: //
Copyright 2016 The Chromium Authors. All rights reserved.
On 2017/03/02 21:54:10, sdefresne wrote:
> 2016 -> 2017

Done.

https://codereview.chromium.org/2726203002/diff/40001/ios/web_view/internal/t...
File ios/web_view/internal/translate/web_view_translate_ranker_factory.h
(right):

https://codereview.chromium.org/2726203002/diff/40001/ios/web_view/internal/t...
ios/web_view/internal/translate/web_view_translate_ranker_factory.h:1: //
Copyright 2016 The Chromium Authors. All rights reserved.
On 2017/03/02 21:54:10, sdefresne wrote:
> 2016 -> 2017

Done.

[fdoray, 2017-03-02 22:06:47]

lgtm

[groby-ooo-7-16, 2017-03-02 22:37:05]

Changes against PS2 LGTM

But: My longer term concern is that this only papers over the performance
regressions. If we ever turn things on by default, we still have the same
problem, IIUC? Are there plans to address that issue?

[hamelphi, 2017-03-02 22:38:03]

The CQ bit was checked by hamelphi@chromium.org

[hamelphi, 2017-03-02 22:38:03]

The patchset sent to the CQ was uploaded after l-g-t-m from asanka@chromium.org,
rkaplow@chromium.org, sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2726203002/#ps80001
(title: "Update year in comments.")

[commit-bot: I haz the power, 2017-03-02 22:38:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hamelphi, 2017-03-02 22:43:03]

On 2017/03/02 22:37:05, groby wrote:
> Changes against PS2 LGTM
> 
> But: My longer term concern is that this only papers over the performance
> regressions. If we ever turn things on by default, we still have the same
> problem, IIUC? Are there plans to address that issue?

Yes, you are correct. Of course we will investigate the issue and solve the
problem before we activate the ModelLoader in Beta/Stable. But, having it in
code controlled by finch will allow us to collect metrics from Canary/Dev to
better understand the problem. The performance regression was seen only for
Windows in a controlled environment. I have not seen any metrics in UMA pointing
to the problem yet.

[hamelphi, 2017-03-02 22:43:56]

Thanks everyone for the quick review. I really appreciate it.

[commit-bot: I haz the power, 2017-03-02 23:38:29]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488494283452310,
"parent_rev": "2df232659f116970f80a6d492ec5945173690e2c", "commit_rev":
"d005809c83c0ad0b9cbbda6b10b7ed2c3dcd5120"}

[commit-bot: I haz the power, 2017-03-02 23:39:13]

Description was changed from

==========
[Translate] Add translate ranker model loader.

This is a revert of a revert. It was originally
https://codereview.chromium.org/2565873002 which was reverted in
https://codereview.chromium.org/2726043003.

Load the TranslateRanker model only if Query is enabled.

This should fix the negative speed regression when Query is not enabled. This
condition is controlled through Finch, and is currently only enabled in Canary
and Dev. This will allow us to better investigate the speed regression using
experimental/control groups.

Also fix the Query/Enforcement logic so that enabling Enforcement automatically
enforce Query.

Revert "Revert "[translate] Add translate ranker model loader.""

This reverts commit 9ea997e1d7bbd4350d8793e1629f33c98d00ce2b.

BUG=697665, 646711
==========

to

==========
[Translate] Add translate ranker model loader.

This is a revert of a revert. It was originally
https://codereview.chromium.org/2565873002 which was reverted in
https://codereview.chromium.org/2726043003.

Load the TranslateRanker model only if Query is enabled.

This should fix the negative speed regression when Query is not enabled. This
condition is controlled through Finch, and is currently only enabled in Canary
and Dev. This will allow us to better investigate the speed regression using
experimental/control groups.

Also fix the Query/Enforcement logic so that enabling Enforcement automatically
enforce Query.

Revert "Revert "[translate] Add translate ranker model loader.""

This reverts commit 9ea997e1d7bbd4350d8793e1629f33c98d00ce2b.

BUG=697665, 646711

Review-Url: https://codereview.chromium.org/2726203002
Cr-Commit-Position: refs/heads/master@{#454433}
Committed:
https://chromium.googlesource.com/chromium/src/+/d005809c83c0ad0b9cbbda6b10b7...
==========

[commit-bot: I haz the power, 2017-03-02 23:39:14]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/d005809c83c0ad0b9cbbda6b10b7...

[hamelphi, 2017-03-07 17:01:10]

Description was changed from

==========
[Translate] Add translate ranker model loader.

This is a revert of a revert. It was originally
https://codereview.chromium.org/2565873002 which was reverted in
https://codereview.chromium.org/2726043003.

Load the TranslateRanker model only if Query is enabled.

This should fix the negative speed regression when Query is not enabled. This
condition is controlled through Finch, and is currently only enabled in Canary
and Dev. This will allow us to better investigate the speed regression using
experimental/control groups.

Also fix the Query/Enforcement logic so that enabling Enforcement automatically
enforce Query.

Revert "Revert "[translate] Add translate ranker model loader.""

This reverts commit 9ea997e1d7bbd4350d8793e1629f33c98d00ce2b.

BUG=697665, 646711

Review-Url: https://codereview.chromium.org/2726203002
Cr-Commit-Position: refs/heads/master@{#454433}
Committed:
https://chromium.googlesource.com/chromium/src/+/d005809c83c0ad0b9cbbda6b10b7...
==========

to

==========
[Translate] Add translate ranker model loader.

This is a revert of a revert. It was originally
https://codereview.chromium.org/2565873002 which was reverted in
https://codereview.chromium.org/2726043003.

Load the TranslateRanker model only if Query is enabled.

This should fix the negative speed regression when Query is not enabled. This
condition is controlled through Finch, and is currently only enabled in Canary
and Dev. This will allow us to better investigate the speed regression using
experimental/control groups.

Also fix the Query/Enforcement logic so that enabling Enforcement automatically
enforce Query.

Revert "Revert "[translate] Add translate ranker model loader.""

This reverts commit 9ea997e1d7bbd4350d8793e1629f33c98d00ce2b.

BUG=697665, 646711, 698057

Review-Url: https://codereview.chromium.org/2726203002
Cr-Commit-Position: refs/heads/master@{#454433}
Committed:
https://chromium.googlesource.com/chromium/src/+/d005809c83c0ad0b9cbbda6b10b7...
==========

[hamelphi, 2017-03-08 13:47:44]

On 2017/03/02 23:39:14, commit-bot: I haz the power wrote:
> Committed patchset #5 (id:80001) as
>
https://chromium.googlesource.com/chromium/src/+/d005809c83c0ad0b9cbbda6b10b7...

This issue has been reverted: https://codereview.chromium.org/2736853004