Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2736853004: Revert "[Translate] Add translate ranker model loader." (Closed)

Created:
3 years, 9 months ago by hamelphi
Modified:
3 years, 9 months ago
Reviewers:
jwd
CC:
chromium-reviews, cbentzel+watch_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, Eugene But (OOO till 7-30), pkl (ping after 24h if needed), ios-reviews+web_chromium.org, net-reviews_chromium.org, noyau+watch_chromium.org, asvitkine+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "[Translate] Add translate ranker model loader." This reverts commit d005809c83c0ad0b9cbbda6b10b7ed2c3dcd5120. This CL causes regression in "Time To First Contentful Pane" for Windows and crashes for ChromeOS BUG=697665, 646711, 698057, 699168 TBR=asanka@chromium.org, groby@chromium.org, fdoray@chromium.org, rkaplow@chromium.org, sdefresne@chromium.org Review-Url: https://codereview.chromium.org/2736853004 Cr-Commit-Position: refs/heads/master@{#455280} Committed: https://chromium.googlesource.com/chromium/src/+/34f5f9f1efc1283d1bb7c284ab0798ac842265fd

Patch Set 1 #

Patch Set 2 : Merge #

Patch Set 3 : Revert "[Translate] Add translate ranker model loader." #

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+729 lines, -2500 lines) Patch
M chrome/browser/BUILD.gn View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/translate/chrome_translate_client.cc View 2 chunks +5 lines, -8 lines 0 comments Download
D chrome/browser/translate/translate_ranker_factory.h View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/translate/translate_ranker_factory.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/translate/translate_ranker_metrics_provider.h View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/translate/translate_ranker_metrics_provider.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M components/translate/core/browser/BUILD.gn View 3 chunks +4 lines, -10 lines 0 comments Download
D components/translate/core/browser/mock_translate_ranker.h View 1 chunk +0 lines, -65 lines 0 comments Download
D components/translate/core/browser/mock_translate_ranker.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M components/translate/core/browser/proto/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D components/translate/core/browser/proto/ranker_model.proto View 1 chunk +0 lines, -49 lines 0 comments Download
M components/translate/core/browser/proto/translate_ranker_model.proto View 2 chunks +2 lines, -5 lines 0 comments Download
D components/translate/core/browser/ranker_model.h View 1 chunk +0 lines, -46 lines 0 comments Download
D components/translate/core/browser/ranker_model.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D components/translate/core/browser/ranker_model_loader.h View 1 chunk +0 lines, -139 lines 0 comments Download
D components/translate/core/browser/ranker_model_loader.cc View 1 chunk +0 lines, -420 lines 0 comments Download
D components/translate/core/browser/ranker_model_loader_unittest.cc View 1 chunk +0 lines, -374 lines 0 comments Download
M components/translate/core/browser/translate_manager.h View 3 chunks +0 lines, -3 lines 0 comments Download
M components/translate/core/browser/translate_manager.cc View 4 chunks +21 lines, -24 lines 0 comments Download
M components/translate/core/browser/translate_manager_unittest.cc View 6 chunks +4 lines, -6 lines 0 comments Download
M components/translate/core/browser/translate_ranker.h View 1 chunk +83 lines, -20 lines 0 comments Download
A components/translate/core/browser/translate_ranker.cc View 1 chunk +311 lines, -0 lines 0 comments Download
D components/translate/core/browser/translate_ranker_impl.h View 1 chunk +0 lines, -136 lines 0 comments Download
D components/translate/core/browser/translate_ranker_impl.cc View 1 chunk +0 lines, -289 lines 0 comments Download
D components/translate/core/browser/translate_ranker_impl_unittest.cc View 1 chunk +0 lines, -341 lines 0 comments Download
A + components/translate/core/browser/translate_ranker_metrics_provider.h View 3 chunks +5 lines, -5 lines 0 comments Download
A components/translate/core/browser/translate_ranker_metrics_provider.cc View 1 chunk +37 lines, -0 lines 0 comments Download
A components/translate/core/browser/translate_ranker_unittest.cc View 1 chunk +236 lines, -0 lines 0 comments Download
M components/translate/core/browser/translate_ui_delegate_unittest.cc View 4 chunks +3 lines, -7 lines 0 comments Download
M components/translate/core/browser/translate_url_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/metrics/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/translate/BUILD.gn View 2 chunks +0 lines, -6 lines 0 comments Download
M ios/chrome/browser/translate/chrome_ios_translate_client.mm View 3 chunks +2 lines, -8 lines 0 comments Download
D ios/chrome/browser/translate/translate_ranker_factory.h View 1 chunk +0 lines, -51 lines 0 comments Download
D ios/chrome/browser/translate/translate_ranker_factory.cc View 1 chunk +0 lines, -50 lines 0 comments Download
D ios/chrome/browser/translate/translate_ranker_metrics_provider.h View 1 chunk +0 lines, -28 lines 0 comments Download
D ios/chrome/browser/translate/translate_ranker_metrics_provider.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M ios/web_view/internal/translate/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/web_view/internal/translate/web_view_translate_client.mm View 2 chunks +0 lines, -4 lines 0 comments Download
D ios/web_view/internal/translate/web_view_translate_ranker_factory.h View 1 chunk +0 lines, -48 lines 0 comments Download
D ios/web_view/internal/translate/web_view_translate_ranker_factory.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M net/url_request/test_url_fetcher_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736853004/60001
3 years, 9 months ago (2017-03-07 19:46:11 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 9 months ago (2017-03-07 19:46:13 UTC) #10
hamelphi
3 years, 9 months ago (2017-03-07 19:46:48 UTC) #12
jwd
lgtm
3 years, 9 months ago (2017-03-07 19:47:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736853004/60001
3 years, 9 months ago (2017-03-07 19:49:14 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 23:20:10 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/34f5f9f1efc1283d1bb7c284ab07...

Powered by Google App Engine
This is Rietveld 408576698