Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2725953003: Fix WTF::HashTable performance regression on Windows. (Closed)

Created:
3 years, 9 months ago by tkent
Modified:
3 years, 9 months ago
Reviewers:
Yuta Kitamura
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix WTF::HashTable performance regression on Windows. https://codereview.chromium.org/2585673002 introduced function calls for empty functions. It seems MSVC doesn't optimize them out. BUG=680512 Review-Url: https://codereview.chromium.org/2725953003 Cr-Commit-Position: refs/heads/master@{#454209} Committed: https://chromium.googlesource.com/chromium/src/+/eecb9420efdea1d6c4e882a85e1de607ed317781

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M third_party/WebKit/Source/wtf/HashTable.h View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
tkent
yutak@, would you review this please? I verified this CL improved Speedometer on Windows clearly.
3 years, 9 months ago (2017-03-02 06:24:43 UTC) #4
Yuta Kitamura
LGTM, that sounds very likely.
3 years, 9 months ago (2017-03-02 06:43:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725953003/1
3 years, 9 months ago (2017-03-02 08:03:47 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 08:09:03 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eecb9420efdea1d6c4e882a85e1d...

Powered by Google App Engine
This is Rietveld 408576698