Fix LayoutUnit snapping of widths in line breaker

Fix LayoutUnit snapping of widths in line breaker

This patch fixes how the line breaker snaps widths at node boundaries.

Before this patch, only uncommitted widths are snapped. This does not
snap widths correctly when:
* All widths are committed.
* There are committed and uncommitted widths.

LayoutBlockFlow::computeInlinePreferredLogicalWidths() snaps the width
of each node. This patch changes the line breaker to do the same
snapping.

BUG=693941
Review-Url: https://codereview.chromium.org/2725933002
Cr-Commit-Position: refs/heads/master@{#454211}
Committed: https://chromium.googlesource.com/chromium/src/+/460361ba8ca8615d1794caa3e6dc517634798b4f

[kojii, 2017-03-01 19:50:26]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 19:50:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-03-01 21:28:40]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 21:28:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-03-01 21:35:24]

Description was changed from

==========
WIP: snapwidth

BUG=
==========

to

==========
Fix LayoutUnit snapping of widths in line breaker

This patch fixes how the line breaker snaps widths at node boundaries.

Before this patch, only uncommitted widths are snapped. This does not
snap widths correctly when:
* All widths are committed.
* There are committed and uncommitted widths.

LayoutBlockFlow::computeInlinePreferredLogicalWidths() snaps the width
of each node. This patch changes the line breaker to do the same
snapping.

BUG=693941
==========

[kojii, 2017-03-01 21:35:40]

kojii@chromium.org changed reviewers:
+ eae@chromium.org

[kojii, 2017-03-01 21:35:40]

PTAL.

[kojii, 2017-03-01 21:38:51]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[kojii, 2017-03-01 21:38:57]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-03-01 21:39:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eae, 2017-03-01 21:54:31]

I'm a little concerned that this might produce widths wider than
computePreferredLogicalWidths but we have good test coverage for that so if the
bots are happy I'm happy.

LGTM

[commit-bot: I haz the power, 2017-03-01 23:20:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 23:20:33]

Dry run: This issue passed the CQ dry run.

[kojii, 2017-03-02 03:04:00]

Thank you as always.

On 2017/03/01 at 21:54:31, eae wrote:
> I'm a little concerned that this might produce widths wider than
computePreferredLogicalWidths but we have good test coverage for that so if the
bots are happy I'm happy.

This should match to computePreferredLogicalWidths if I'm not mistaken.

Compared to before the patch, wider if !m_uncommittedWidth, narrower if
m_uncommittedWidth.

[kojii, 2017-03-02 03:52:55]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 03:54:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-03-02 03:55:03]

Added test cases for !m_uncommittedWidth where it may be wider then before the
patch.

[kojii, 2017-03-02 05:36:07]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[kojii, 2017-03-02 05:36:33]

Patchset #3 (id:60001) has been deleted

[commit-bot: I haz the power, 2017-03-02 05:37:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 08:23:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 08:23:23]

Dry run: This issue passed the CQ dry run.

[kojii, 2017-03-02 08:23:44]

The CQ bit was checked by kojii@chromium.org

[kojii, 2017-03-02 08:23:45]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2725933002/#ps80001
(title: "Add test cases for m_uncommittedWidth and !m_uncommittedWidth")

[commit-bot: I haz the power, 2017-03-02 08:23:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 08:28:07]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488443024537330,
"parent_rev": "2b338ea073b62cbd75b0a9971a3e126c81847f35", "commit_rev":
"460361ba8ca8615d1794caa3e6dc517634798b4f"}

[commit-bot: I haz the power, 2017-03-02 08:28:43]

Description was changed from

==========
Fix LayoutUnit snapping of widths in line breaker

This patch fixes how the line breaker snaps widths at node boundaries.

Before this patch, only uncommitted widths are snapped. This does not
snap widths correctly when:
* All widths are committed.
* There are committed and uncommitted widths.

LayoutBlockFlow::computeInlinePreferredLogicalWidths() snaps the width
of each node. This patch changes the line breaker to do the same
snapping.

BUG=693941
==========

to

==========
Fix LayoutUnit snapping of widths in line breaker

This patch fixes how the line breaker snaps widths at node boundaries.

Before this patch, only uncommitted widths are snapped. This does not
snap widths correctly when:
* All widths are committed.
* There are committed and uncommitted widths.

LayoutBlockFlow::computeInlinePreferredLogicalWidths() snaps the width
of each node. This patch changes the line breaker to do the same
snapping.

BUG=693941

Review-Url: https://codereview.chromium.org/2725933002
Cr-Commit-Position: refs/heads/master@{#454211}
Committed:
https://chromium.googlesource.com/chromium/src/+/460361ba8ca8615d1794caa3e6dc...
==========

[commit-bot: I haz the power, 2017-03-02 08:28:45]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/460361ba8ca8615d1794caa3e6dc...