third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h - Issue 2725933002: Fix LayoutUnit snapping of widths in line breaker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

Issue 2725933002: Fix LayoutUnit snapping of widths in line breaker (Closed)

Patch Set: Add test cases for m_uncommittedWidth and !m_uncommittedWidth Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/text/fit-content-with-element-boundaries.html ('k') | third_party/WebKit/Source/core/layout/line/LineWidth.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

diff --git a/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h b/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

index 07d43ece65b97bcf069bac23c6554eab51dd45e8..580cea082ce674de0c964ca12a39741b67cc09a6 100644

--- a/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

+++ b/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

@@ -382,7 +382,7 @@ inline void BreakingContext::increment() {

// When the line box tree is created, this position in the line will be

// snapped to LayoutUnit's, and those measurements will be used by the paint

// code. Do the equivalent snapping here, to get consistent line measurements.

- m_width.snapUncommittedWidth();

+ m_width.snapAtNodeBoundary();

m_atStart = false;

}