Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2725853004: DevTools: finalize audits2 worker as remote module (Closed)

Created:
3 years, 9 months ago by paulirish
Modified:
3 years, 9 months ago
Reviewers:
chenwilliam, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: finalize audits2 worker as remote module BUG=686149 Review-Url: https://codereview.chromium.org/2725853004 Cr-Commit-Position: refs/heads/master@{#454489} Committed: https://chromium.googlesource.com/chromium/src/+/cbfa0cc27ff472e0911c74160eb05d87d4c14a2b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
paulirish
CL https://codereview.chromium.org/2658233003 was intended to flip lighthouse to a remote module However it did not ...
3 years, 9 months ago (2017-03-03 01:26:28 UTC) #2
pfeldman
lgtm
3 years, 9 months ago (2017-03-03 01:34:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725853004/1
3 years, 9 months ago (2017-03-03 01:35:41 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 03:09:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cbfa0cc27ff472e0911c74160eb0...

Powered by Google App Engine
This is Rietveld 408576698