Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2658233003: DevTools: flip lighthouse binary to be a remote module. (Closed)

Created:
3 years, 10 months ago by paulirish
Modified:
3 years, 10 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, chenwilliam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: flip lighthouse binary to be a remote module. BUG=686149 Review-Url: https://codereview.chromium.org/2658233003 Cr-Commit-Position: refs/heads/master@{#446765} Committed: https://chromium.googlesource.com/chromium/src/+/e358e50b02e5dca9633b9a96291c659871b56fe5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/audits2_worker.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
paulirish
ptal
3 years, 10 months ago (2017-01-27 18:52:46 UTC) #2
pfeldman
lgtm
3 years, 10 months ago (2017-01-27 19:10:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658233003/1
3 years, 10 months ago (2017-01-27 19:10:58 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 21:00:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e358e50b02e5dca9633b9a96291c...

Powered by Google App Engine
This is Rietveld 408576698