Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2725803007: Extend Physical Web iOS auto-enable behavior beyond first launch. (Closed)

Created:
3 years, 9 months ago by mmocny
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Extend Physical Web iOS auto-enable behavior beyond first launch. On Chrome start, we check whether the device state permits us to auto-enable the Physical Web feature to perform foreground scanning for nearby Bluetooth LE devices broadcasting URLs. Previously, if the auto-enable conditions were not met, the Physical Web preference would be set to the explicitly-disabled state. With this change, the preference is left in an onboarding state and Chrome will check again the next time Chrome is started. BUG=695184 Review-Url: https://codereview.chromium.org/2704343005 Cr-Commit-Position: refs/heads/master@{#452571} (cherry picked from commit 0e3b410bacaa28cde0c2be4c2eba96451c6ca72a) Review-Url: https://codereview.chromium.org/2725803007 . Cr-Commit-Position: refs/branch-heads/2987@{#742} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/b5bdcfde2530d5802d896df554536acdffe9ac3c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M ios/chrome/browser/physical_web/start_physical_web_discovery.mm View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mmocny
3 years, 9 months ago (2017-03-02 20:41:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b5bdcfde2530d5802d896df554536acdffe9ac3c.

Powered by Google App Engine
This is Rietveld 408576698