Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 2704343005: Extend Physical Web iOS auto-enable behavior beyond first launch. (Closed)

Created:
3 years, 10 months ago by mattreynolds
Modified:
3 years, 10 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extend Physical Web iOS auto-enable behavior beyond first launch. On Chrome start, we check whether the device state permits us to auto-enable the Physical Web feature to perform foreground scanning for nearby Bluetooth LE devices broadcasting URLs. Previously, if the auto-enable conditions were not met, the Physical Web preference would be set to the explicitly-disabled state. With this change, the preference is left in an onboarding state and Chrome will check again the next time Chrome is started. BUG=695184 Review-Url: https://codereview.chromium.org/2704343005 Cr-Commit-Position: refs/heads/master@{#452571} Committed: https://chromium.googlesource.com/chromium/src/+/0e3b410bacaa28cde0c2be4c2eba96451c6ca72a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M ios/chrome/browser/physical_web/start_physical_web_discovery.mm View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mattreynolds
Hi Sylvain, PTAL.
3 years, 10 months ago (2017-02-22 22:45:34 UTC) #2
sdefresne
lgtm
3 years, 10 months ago (2017-02-23 11:10:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704343005/1
3 years, 10 months ago (2017-02-23 18:48:48 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 19:02:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0e3b410bacaa28cde0c2be4c2eba...

Powered by Google App Engine
This is Rietveld 408576698