scheduler: Suspend timers while virtual time is paused

scheduler: Suspend timers while virtual time is paused

When virtual time is suspended, suspend all timers from running -- even
if they would be eligible to run given the current virtual time value.
This allows us to deterministically schedule fetch responses w.r.t. all
types of timers tasks regardless of how soon the fetch request is
serviced. The downside is that the throughput of timer work is reduced
depending on the number of fetches performed by a page.

Design doc:
https://docs.google.com/document/d/19s2g4fPP9p9qmMZvwPX8uDGbb-39rgR9k56B4B-ueG8/edit?pli=1#

BUG=696001
Review-Url: https://codereview.chromium.org/2725633002
Cr-Commit-Position: refs/heads/master@{#455787}
Committed: https://chromium.googlesource.com/chromium/src/+/31b966ba7c5468ada998bb46e605a4d733b69202

[Sami, 2017-02-28 12:34:04]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 12:34:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 13:06:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 13:06:24]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Sami, 2017-02-28 14:48:16]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 14:48:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 15:01:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 15:01:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sami, 2017-03-01 15:06:37]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 15:06:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 15:19:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 15:19:07]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Sami, 2017-03-02 11:26:16]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 11:26:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 12:02:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 12:02:46]

Dry run: CQ cannot get SignCLA result. Please try later.

[Sami, 2017-03-07 14:00:12]

Description was changed from

==========
DO NOT COMMIT: Suspend timers while virtual time is paused

BUG=
==========

to

==========
scheduler: Suspend timers while virtual time is paused

When virtual time is suspended, suspend all timers from running -- even
if they would be eligible to run given the current virtual time value.
This allows us to deterministically schedule fetch responses w.r.t. all
types of timers tasks regardless of how soon the fetch request is
serviced. The downside is that the throughput of timer work is reduced
depending on the number of fetches performed by a page.

Design doc:
https://docs.google.com/document/d/19s2g4fPP9p9qmMZvwPX8uDGbb-39rgR9k56B4B-ue...

BUG=696001
==========

[Sami, 2017-03-07 14:01:20]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 14:02:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sami, 2017-03-07 14:31:17]

skyostil@chromium.org changed reviewers:
+ alexclarke@chromium.org

[commit-bot: I haz the power, 2017-03-07 18:37:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 18:37:39]

Dry run: This issue passed the CQ dry run.

[alex clarke (OOO till 29th), 2017-03-09 11:11:33]

lgtm

https://codereview.chromium.org/2725633002/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
(right):

https://codereview.chromium.org/2725633002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc:1207:
task_queue->SetTimeDomain(real_time_domain());
Setting this redundantly is cheap.  Maybe just move this into the two non
virtual if clauses below for clarity?

[Sami, 2017-03-09 11:25:32]

skyostil@chromium.org changed reviewers:
+ haraken@chromium.org

[Sami, 2017-03-09 11:25:33]

Thanks!

Kentaro, could you check third_party/WebKit/public/platform/WebViewScheduler.h
please?

https://codereview.chromium.org/2725633002/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
(right):

https://codereview.chromium.org/2725633002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc:1207:
task_queue->SetTimeDomain(real_time_domain());
On 2017/03/09 11:11:33, alex clarke wrote:
> Setting this redundantly is cheap.  Maybe just move this into the two non
> virtual if clauses below for clarity?

Done. (FWIW setting this takes a lock, but I think this transition happens
rarely enough that it doesn't matter.)

[Sami, 2017-03-09 11:26:45]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 11:27:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-03-09 12:19:34]

LGTM

[Sami, 2017-03-09 12:25:54]

The CQ bit was unchecked by skyostil@chromium.org

[Sami, 2017-03-09 12:26:01]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2017-03-09 12:26:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
alexclarke@chromium.org
Link to the patchset: https://codereview.chromium.org/2725633002/#ps100001
(title: "Review comments")

[commit-bot: I haz the power, 2017-03-09 12:26:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 12:44:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 12:44:39]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sami, 2017-03-09 13:40:55]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2017-03-09 13:40:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, alexclarke@chromium.org
Link to the patchset: https://codereview.chromium.org/2725633002/#ps120001
(title: "Fix test failure")

[commit-bot: I haz the power, 2017-03-09 13:41:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 14:17:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 14:17:58]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sami, 2017-03-09 16:21:17]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2017-03-09 16:21:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, alexclarke@chromium.org
Link to the patchset: https://codereview.chromium.org/2725633002/#ps140001
(title: "Rebased")

[commit-bot: I haz the power, 2017-03-09 16:21:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 17:48:21]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1489076477812990,
"parent_rev": "aa3f4d5c4ade03f9abc1989c2f03f025fb692ec0", "commit_rev":
"31b966ba7c5468ada998bb46e605a4d733b69202"}

[commit-bot: I haz the power, 2017-03-09 17:49:17]

Description was changed from

==========
scheduler: Suspend timers while virtual time is paused

When virtual time is suspended, suspend all timers from running -- even
if they would be eligible to run given the current virtual time value.
This allows us to deterministically schedule fetch responses w.r.t. all
types of timers tasks regardless of how soon the fetch request is
serviced. The downside is that the throughput of timer work is reduced
depending on the number of fetches performed by a page.

Design doc:
https://docs.google.com/document/d/19s2g4fPP9p9qmMZvwPX8uDGbb-39rgR9k56B4B-ue...

BUG=696001
==========

to

==========
scheduler: Suspend timers while virtual time is paused

When virtual time is suspended, suspend all timers from running -- even
if they would be eligible to run given the current virtual time value.
This allows us to deterministically schedule fetch responses w.r.t. all
types of timers tasks regardless of how soon the fetch request is
serviced. The downside is that the throughput of timer work is reduced
depending on the number of fetches performed by a page.

Design doc:
https://docs.google.com/document/d/19s2g4fPP9p9qmMZvwPX8uDGbb-39rgR9k56B4B-ue...

BUG=696001

Review-Url: https://codereview.chromium.org/2725633002
Cr-Commit-Position: refs/heads/master@{#455787}
Committed:
https://chromium.googlesource.com/chromium/src/+/31b966ba7c5468ada998bb46e605...
==========

[commit-bot: I haz the power, 2017-03-09 17:49:20]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/31b966ba7c5468ada998bb46e605...