Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc

Issue 2725633002: scheduler: Suspend timers while virtual time is paused (Closed)
Patch Set: Rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc b/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc
index 61961b6a1242088976675f368cd0b26760b9b622..c3aa5444a77f6a53efad29f9d54bb024f4112248 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc
@@ -390,8 +390,8 @@ TEST_F(WebViewSchedulerImplTest, VirtualTime_NotAllowedToAdvance) {
mock_task_runner_->RunUntilIdle();
- // Immediate tasks are allowed to run even if delayed tasks are not.
- EXPECT_THAT(run_order, ElementsAre(0));
+ // No timer tasks are allowed to run.
+ EXPECT_THAT(run_order, ElementsAre());
}
TEST_F(WebViewSchedulerImplTest, VirtualTime_AllowedToAdvance) {
@@ -606,6 +606,27 @@ TEST_F(WebViewSchedulerImplTest, BackgroundParser_DETERMINISTIC_LOADING) {
EXPECT_TRUE(web_view_scheduler_->virtualTimeAllowedToAdvance());
}
+TEST_F(WebViewSchedulerImplTest, SuspendTimersWhileVirtualTimeIsPaused) {
+ std::vector<int> run_order;
+
+ std::unique_ptr<WebFrameSchedulerImpl> web_frame_scheduler =
+ web_view_scheduler_->createWebFrameSchedulerImpl(nullptr);
+ web_frame_scheduler->timerTaskRunner()->postDelayedTask(
+ BLINK_FROM_HERE, WTF::bind(&runOrderTask, 1, WTF::unretained(&run_order)),
+ 0);
+
+ web_view_scheduler_->setVirtualTimePolicy(VirtualTimePolicy::PAUSE);
+ web_view_scheduler_->enableVirtualTime();
+
+ mock_task_runner_->RunUntilIdle();
+ EXPECT_TRUE(run_order.empty());
+
+ web_view_scheduler_->setVirtualTimePolicy(VirtualTimePolicy::ADVANCE);
+ mock_task_runner_->RunUntilIdle();
+
+ EXPECT_THAT(run_order, ElementsAre(1));
+}
+
namespace {
using ScopedExpensiveBackgroundTimerThrottlingForTest =

Powered by Google App Engine
This is Rietveld 408576698