Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2725333004: Omnibox - Cleanup From Recent Changelists (Closed)

Created:
3 years, 9 months ago by Mark P
Modified:
3 years, 9 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, jdonnelly+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Omnibox - Cleanup From Recent Changelists Includes code polish requested mainly on https://codereview.chromium.org/2717893002/ and one request on https://codereview.chromium.org/2726413002/ BUG= Review-Url: https://codereview.chromium.org/2725333004 Cr-Commit-Position: refs/heads/master@{#454720} Committed: https://chromium.googlesource.com/chromium/src/+/c90c24bbb9e18ea9e90e34fa2ed975435be403c3

Patch Set 1 #

Total comments: 2

Patch Set 2 : DCHECK(done_) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M components/omnibox/browser/search_provider.h View 1 chunk +4 lines, -3 lines 0 comments Download
M components/omnibox/browser/search_provider.cc View 1 1 chunk +2 lines, -6 lines 0 comments Download
M components/omnibox/browser/zero_suggest_provider.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (13 generated)
Mark P
Feel free to review this at your leisure. cheers, mark
3 years, 9 months ago (2017-03-03 22:13:27 UTC) #3
Peter Kasting
https://codereview.chromium.org/2725333004/diff/1/components/omnibox/browser/search_provider.cc File components/omnibox/browser/search_provider.cc (right): https://codereview.chromium.org/2725333004/diff/1/components/omnibox/browser/search_provider.cc#newcode276 components/omnibox/browser/search_provider.cc:276: DCHECK(keyword_fetcher_ != nullptr); This seems backwards. I'd think we'd ...
3 years, 9 months ago (2017-03-03 23:13:46 UTC) #8
Mark P
https://codereview.chromium.org/2725333004/diff/1/components/omnibox/browser/search_provider.cc File components/omnibox/browser/search_provider.cc (right): https://codereview.chromium.org/2725333004/diff/1/components/omnibox/browser/search_provider.cc#newcode276 components/omnibox/browser/search_provider.cc:276: DCHECK(keyword_fetcher_ != nullptr); On 2017/03/03 23:13:46, Peter Kasting wrote: ...
3 years, 9 months ago (2017-03-03 23:22:26 UTC) #9
Peter Kasting
LGTM
3 years, 9 months ago (2017-03-03 23:27:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725333004/20001
3 years, 9 months ago (2017-03-04 00:07:42 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-04 00:12:15 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c90c24bbb9e18ea9e90e34fa2ed9...

Powered by Google App Engine
This is Rietveld 408576698