Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: components/omnibox/browser/search_provider.cc

Issue 2725333004: Omnibox - Cleanup From Recent Changelists (Closed)
Patch Set: DCHECK(done_) Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/omnibox/browser/search_provider.h ('k') | components/omnibox/browser/zero_suggest_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/omnibox/browser/search_provider.cc
diff --git a/components/omnibox/browser/search_provider.cc b/components/omnibox/browser/search_provider.cc
index 830f160e735d13350bf633ac36a4452d4c2bcf93..79ba8ae307614650b452885f828e000df0868328 100644
--- a/components/omnibox/browser/search_provider.cc
+++ b/components/omnibox/browser/search_provider.cc
@@ -271,12 +271,8 @@ void SearchProvider::Start(const AutocompleteInput& input,
providers_.set(default_provider_keyword, keyword_provider_keyword);
if (input.from_omnibox_focus()) {
- // Don't display any suggestions for on-focus requests. Stop any pending
- // requests here (there likely aren't yet, though it doesn't hurt to be safe
- // so that we can create a new request later in this flow (to warm-up the
- // suggest server by alerting it that the user is likely about to start
- // typing).
- StopSuggest();
+ // Don't display any suggestions for on-focus requests.
+ DCHECK(done_);
ClearAllResults();
} else if (input.text().empty()) {
// User typed "?" alone. Give them a placeholder result indicating what
« no previous file with comments | « components/omnibox/browser/search_provider.h ('k') | components/omnibox/browser/zero_suggest_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698