Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2725323002: Revert of [Telemetry][Wpr] Remove old version of archive info. (Closed)

Created:
3 years, 9 months ago by perezju
Modified:
3 years, 9 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org, charliea (OOO until 10-5)
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of [Telemetry][Wpr] Remove old version of archive info. (patchset #3 id:40001 of https://codereview.chromium.org/2694843002/ ) Reason for revert: Broke catapult autoroller, failing with: File "e:\b\swarm_slave\w\irddo0yd\third_party\catapult\telemetry\third_party\mock\mock.py", line 1091, in _dot_lookup __import__(import_path) ImportError: No module named archive_info2 https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/377472 Original issue's description: > [Telemetry][Wpr] Remove old version of archive info. > > BUG=chromium:618698 > > Review-Url: https://codereview.chromium.org/2694843002 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/7f38bdac42989779f5bd19d5a5acd7eb68f9f371 TBR=nednguyen@google.com,charliea@chromium.org,rnephew@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:618698 Review-Url: https://codereview.chromium.org/2725323002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/1b305da0d509f4122732296a8581fd8ff48dc4c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+919 lines, -439 lines) Patch
M telemetry/telemetry/internal/story_runner_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/testing/test_page_sets/data/example_domain.json View 1 chunk +5 lines, -8 lines 0 comments Download
M telemetry/telemetry/wpr/archive_info.py View 10 chunks +78 lines, -64 lines 0 comments Download
A telemetry/telemetry/wpr/archive_info2.py View 1 chunk +219 lines, -0 lines 0 comments Download
A telemetry/telemetry/wpr/archive_info2_unittest.py View 1 chunk +406 lines, -0 lines 0 comments Download
M telemetry/telemetry/wpr/archive_info_unittest.py View 2 chunks +209 lines, -365 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
perezju
Created Revert of [Telemetry][Wpr] Remove old version of archive info.
3 years, 9 months ago (2017-03-03 12:49:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725323002/1
3 years, 9 months ago (2017-03-03 12:49:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/1b305da0d509f4122732296a8581fd8ff48dc4c7
3 years, 9 months ago (2017-03-03 12:49:18 UTC) #6
rnephew (Reviews Here)
3 years, 9 months ago (2017-03-03 17:12:27 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2731753002/ by rnephew@chromium.org.

The reason for reverting is: Fix landed..

Powered by Google App Engine
This is Rietveld 408576698