Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2694843002: [Telemetry][Wpr] Remove old version of archive info. (Closed)

Created:
3 years, 10 months ago by rnephew (Reviews Here)
Modified:
3 years, 9 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org, charliea (OOO until 10-5)
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix refs to archive_info2 #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+400 lines, -880 lines) Patch
M telemetry/telemetry/internal/story_runner_unittest.py View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/testing/test_page_sets/data/example_domain.json View 1 chunk +8 lines, -5 lines 0 comments Download
M telemetry/telemetry/wpr/archive_info.py View 1 10 chunks +63 lines, -77 lines 0 comments Download
D telemetry/telemetry/wpr/archive_info2.py View 1 chunk +0 lines, -219 lines 0 comments Download
D telemetry/telemetry/wpr/archive_info2_unittest.py View 1 chunk +0 lines, -406 lines 0 comments Download
M telemetry/telemetry/wpr/archive_info_unittest.py View 2 chunks +327 lines, -171 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
rnephew (Reviews Here)
3 years, 10 months ago (2017-02-13 18:31:21 UTC) #2
nednguyen
On 2017/02/13 18:31:21, rnephew (Reviews Here) wrote: Just to make sure, have you sent an ...
3 years, 10 months ago (2017-02-13 21:11:24 UTC) #5
nednguyen
On 2017/02/13 21:11:24, nednguyen wrote: > On 2017/02/13 18:31:21, rnephew (Reviews Here) wrote: > > ...
3 years, 10 months ago (2017-02-13 21:12:09 UTC) #6
rnephew (Reviews Here)
On 2017/02/13 21:12:09, nednguyen wrote: > On 2017/02/13 21:11:24, nednguyen wrote: > > On 2017/02/13 ...
3 years, 10 months ago (2017-02-13 23:44:10 UTC) #7
charliea (OOO until 10-5)
Removed myself from the reviewers: please re-add me when you need the review.
3 years, 10 months ago (2017-02-22 15:17:42 UTC) #11
rnephew (Reviews Here)
Ping since it has been > 2 weeks since I sent out the warning email. ...
3 years, 9 months ago (2017-03-02 16:09:13 UTC) #12
nednguyen
lgtm
3 years, 9 months ago (2017-03-02 16:11:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694843002/40001
3 years, 9 months ago (2017-03-02 16:28:37 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/7f38bdac42989779f5bd19d5a5acd7eb68f9f371
3 years, 9 months ago (2017-03-02 16:50:35 UTC) #19
perezju
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2725323002/ by perezju@chromium.org. ...
3 years, 9 months ago (2017-03-03 12:49:03 UTC) #20
rnephew (Reviews Here)
3 years, 9 months ago (2017-03-03 15:57:14 UTC) #21
Message was sent while issue was closed.
On 2017/03/03 12:49:03, perezju wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/2725323002/ by mailto:perezju@chromium.org.
> 
> The reason for reverting is: Broke catapult autoroller, failing with:
> 
>     File
>
"e:\b\swarm_slave\w\irddo0yd\third_party\catapult\telemetry\third_party\mock\mock.py",
> line 1091, in _dot_lookup
>       __import__(import_path)
>   ImportError: No module named archive_info2
>
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64....

Woops. Chromium test that relies on catapult that I forgot to fix. Fixing now
and will revert the revert.

Powered by Google App Engine
This is Rietveld 408576698