Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2725293003: [Chromecast] Respect "ignore-certificate-errors" in connectivity_checker (Closed)

Created:
3 years, 9 months ago by wzhong
Modified:
3 years, 9 months ago
CC:
chromium-reviews, alokp+watch_chromium.org, cbentzel+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Respect "ignore-certificate-errors" in connectivity_checker Connectivity_checker should ignore SSL Certificate error and continue when command line switch "ignore-certificate-errors" is specified. The switch is only used in test environment so it is safe. BUG= internal b/35934328 Test= manual test accessing HTTPS URL with invalid system time. Review-Url: https://codereview.chromium.org/2725293003 Cr-Commit-Position: refs/heads/master@{#454892} Committed: https://chromium.googlesource.com/chromium/src/+/ce4e878da9098e3c124e6f13084487c369962417

Patch Set 1 #

Patch Set 2 : Get ignore_certificate_errors setting from url_request_ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M chromecast/browser/url_request_context_factory.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download
M chromecast/net/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M chromecast/net/connectivity_checker_impl.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
wzhong
3 years, 9 months ago (2017-03-03 21:50:20 UTC) #4
almasrymina
On 2017/03/03 21:50:20, wzhong wrote: lgtm.
3 years, 9 months ago (2017-03-04 00:25:09 UTC) #5
halliwell
On 2017/03/04 00:25:09, almasrymina wrote: > On 2017/03/03 21:50:20, wzhong wrote: > > lgtm. lgtm
3 years, 9 months ago (2017-03-04 01:58:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725293003/20001
3 years, 9 months ago (2017-03-04 03:59:10 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/378342)
3 years, 9 months ago (2017-03-04 04:08:01 UTC) #10
wzhong
+ net OWNERS for changes (of order) in DEPS.
3 years, 9 months ago (2017-03-04 04:11:30 UTC) #12
Julia Tuttle
On 2017/03/04 04:11:30, wzhong wrote: > + net OWNERS for changes (of order) in DEPS. ...
3 years, 9 months ago (2017-03-06 16:49:54 UTC) #13
wzhong
On 2017/03/06 16:49:54, Julia Tuttle wrote: > On 2017/03/04 04:11:30, wzhong wrote: > > + ...
3 years, 9 months ago (2017-03-06 18:11:57 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725293003/20001
3 years, 9 months ago (2017-03-06 18:12:39 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 18:26:13 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ce4e878da9098e3c124e6f130844...

Powered by Google App Engine
This is Rietveld 408576698