[Chromecast] Respect "ignore-certificate-errors" in connectivity_checker

chromecast/browser/url_request_context_factory.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/browser/url_request_context_factory.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
@@ skipping 55 matching lines @@
 
   net::ct::EVPolicyCompliance DoesConformToCTEVPolicy(
       net::X509Certificate* cert,
       const net::ct::EVCertsWhitelist* ev_whitelist,
       const net::SCTList& verified_scts,
       const net::NetLogWithSource& net_log) override {
     return net::ct::EVPolicyCompliance::EV_POLICY_DOES_NOT_APPLY;
   }
 };
 
+bool IgnoreCertificateErrors() {
+  base::CommandLine* cmd_line = base::CommandLine::ForCurrentProcess();
+  return cmd_line->HasSwitch(switches::kIgnoreCertificateErrors);
+}
+
 }  // namespace
 
 // Private classes to expose URLRequestContextGetter that call back to the
 // URLRequestContextFactory to create the URLRequestContext on demand.
 //
 // The URLRequestContextFactory::URLRequestContextGetter class is used for both
 // the system and media URLRequestCotnexts.
 class URLRequestContextFactory::URLRequestContextGetter
     : public net::URLRequestContextGetter {
  public:
@@ skipping 243 matching lines @@
   params->proxy_service = proxy_service_.get();
 
   LOG(INFO) << "Set HttpNetworkSessionParams.enable_quic = " << enable_quic_;
   params->enable_quic = enable_quic_;
 }
 
 net::URLRequestContext* URLRequestContextFactory::CreateSystemRequestContext() {
   DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
   InitializeSystemContextDependencies();
   net::HttpNetworkSession::Params system_params;
-  PopulateNetworkSessionParams(false, &system_params);
+  PopulateNetworkSessionParams(IgnoreCertificateErrors(), &system_params);
   system_transaction_factory_.reset(new net::HttpNetworkLayer(
       new net::HttpNetworkSession(system_params)));
   system_job_factory_.reset(new net::URLRequestJobFactoryImpl());
   system_cookie_store_ =
       content::CreateCookieStore(content::CookieStoreConfig());
 
   net::URLRequestContext* system_context = new net::URLRequestContext();
   system_context->set_host_resolver(host_resolver_.get());
   system_context->set_channel_id_service(channel_id_service_.get());
   system_context->set_cert_verifier(cert_verifier_.get());
@@ skipping 35 matching lines @@
   return media_context;
 }
 
 net::URLRequestContext* URLRequestContextFactory::CreateMainRequestContext(
     const base::FilePath& cookie_path,
     content::ProtocolHandlerMap* protocol_handlers,
     content::URLRequestInterceptorScopedVector request_interceptors) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
   InitializeSystemContextDependencies();
 
-  bool ignore_certificate_errors = false;
-  base::CommandLine* cmd_line = base::CommandLine::ForCurrentProcess();
-  if (cmd_line->HasSwitch(switches::kIgnoreCertificateErrors)) {
-    ignore_certificate_errors = true;
-  }
   net::HttpNetworkSession::Params network_session_params;
-  PopulateNetworkSessionParams(ignore_certificate_errors,
+  PopulateNetworkSessionParams(IgnoreCertificateErrors(),
                                &network_session_params);
   InitializeMainContextDependencies(
       new net::HttpNetworkLayer(
           new net::HttpNetworkSession(network_session_params)),
       protocol_handlers, std::move(request_interceptors));
 
   content::CookieStoreConfig cookie_config(
       cookie_path, content::CookieStoreConfig::PERSISTANT_SESSION_COOKIES,
       nullptr, nullptr);
   main_cookie_store_ = content::CreateCookieStore(cookie_config);
@@ skipping 60 matching lines @@
   if (media_getter_) {
     media_getter_->GetURLRequestContext()
         ->http_transaction_factory()
         ->GetSession()
         ->DisableQuic();
   }
 }
 
 }  // namespace shell
 }  // namespace chromecast