Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2725093003: Recover correctly from empty optional parameters. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
Paul Berry, karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -34 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 1 chunk +5 lines, -1 line 0 comments Download
M tests/co19/co19-kernel.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/language_kernel.status View 1 chunk +0 lines, -28 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
One reviewer should be enough.
3 years, 9 months ago (2017-03-02 16:09:28 UTC) #2
Paul Berry
lgtm
3 years, 9 months ago (2017-03-02 16:37:53 UTC) #3
ahe
3 years, 9 months ago (2017-03-03 09:26:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
790df00dc612f8e6d3898a9e19f684b000ed9c8f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698