pkg/front_end/lib/src/fasta/kernel/body_builder.dart - Issue 2725093003: Recover correctly from empty optional parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/front_end/lib/src/fasta/kernel/body_builder.dart

Issue 2725093003: Recover correctly from empty optional parameters. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/front_end/lib/src/fasta/kernel/body_builder.dart

diff --git a/pkg/front_end/lib/src/fasta/kernel/body_builder.dart b/pkg/front_end/lib/src/fasta/kernel/body_builder.dart

index cda53c04829a512672b2a6dbb42c02bbc4e9784d..a06884ee7e279942d48cc930de0ac85fbff6a4ca 100644

--- a/pkg/front_end/lib/src/fasta/kernel/body_builder.dart

+++ b/pkg/front_end/lib/src/fasta/kernel/body_builder.dart

@@ -1321,7 +1321,7 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {

FormalParameterType kind = optional("{", beginToken)

? FormalParameterType.NAMED

: FormalParameterType.POSITIONAL;

- push(new OptionalFormals(kind, popList(count)));

+ push(new OptionalFormals(kind, popList(count) ?? []));

}

@override

« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/kernel/kernel_target.dart » ('j') | no next file with comments »