Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 2725973004: Correctly recover from incorrect imports, etc. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
Paul Berry, karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -57 lines) Patch
M pkg/front_end/lib/src/fasta/parser/class_member_parser.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/listener.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 2 chunks +24 lines, -12 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/stack_listener.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/co19/co19-kernel.status View 3 chunks +0 lines, -44 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (3 generated)
ahe
I just need a review from one of you.
3 years, 9 months ago (2017-03-02 15:12:50 UTC) #3
Paul Berry
lgtm
3 years, 9 months ago (2017-03-02 16:44:50 UTC) #4
ahe
3 years, 9 months ago (2017-03-03 09:10:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
6f550ef4eae139ab20bd50010785960575e74000 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698