Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 272503011: Add functions for inspecting SkShader. (Closed)

Created:
6 years, 7 months ago by scroggo
Modified:
6 years, 7 months ago
Reviewers:
djsollen, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add functions for inspecting SkShader. Add a function to inspect an SkShader to determine if it is an SkComposeShader. Add a virtual function for determining if an SkShader is a custom shader, which returns a custom set of information. The implementation is in Android, and this function is only defined if SK_BUILD_FOR_ANDROID_FRAMEWORK. BUG=b/10650594

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M include/core/SkComposeShader.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/core/SkShader.h View 1 3 chunks +23 lines, -0 lines 0 comments Download
M src/core/SkComposeShader.cpp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scroggo
6 years, 7 months ago (2014-05-07 22:32:26 UTC) #1
reed1
lgtm https://codereview.chromium.org/272503011/diff/1/include/core/SkShader.h File include/core/SkShader.h (right): https://codereview.chromium.org/272503011/diff/1/include/core/SkShader.h#newcode368 include/core/SkShader.h:368: virtual bool asACompose(ComposeRec* rec) const { return false; ...
6 years, 7 months ago (2014-05-07 22:35:36 UTC) #2
scroggo
https://codereview.chromium.org/272503011/diff/1/include/core/SkShader.h File include/core/SkShader.h (right): https://codereview.chromium.org/272503011/diff/1/include/core/SkShader.h#newcode368 include/core/SkShader.h:368: virtual bool asACompose(ComposeRec* rec) const { return false; } ...
6 years, 7 months ago (2014-05-07 22:53:11 UTC) #3
djsollen
The CQ bit was checked by djsollen@google.com
6 years, 7 months ago (2014-05-13 15:52:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/272503011/20001
6 years, 7 months ago (2014-05-13 15:52:33 UTC) #5
djsollen
6 years, 7 months ago (2014-05-13 17:16:22 UTC) #6
uploaded a new CL that is a rebase of this one since I can't add a new patch set
to this issue.

https://codereview.chromium.org/282733005/

Powered by Google App Engine
This is Rietveld 408576698